8000 Remove cobbler internal python tftp daemon implementation by watologo1 · Pull Request #2512 · cobbler/cobbler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove cobbler internal python tftp daemon implementation #2512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2021
Merged

Remove cobbler internal python tftp daemon implementation #2512

merged 2 commits into from
Mar 5, 2021

Conversation

watologo1
Copy link
Contributor

No description provided.

@watologo1 watologo1 requested review from brejoc and SchoolGuy January 9, 2021 12:42
@SchoolGuy SchoolGuy added this to the v3.3.0 milestone Jan 11, 2021
@SchoolGuy
Copy link
Member

We will merge this for 3.3.0 so we don't introduce breaking changes in a minor version. Otherweise fine by me!

@SchoolGuy SchoolGuy self-assigned this Jan 11, 2021
@SchoolGuy
Copy link
Member

@watologo1 Please rebase onto master as our CI has changed and I want to be sure that this causes no side effects.

@SchoolGuy SchoolGuy marked this pull request as draft January 16, 2021 11:07
SchoolGuy
SchoolGuy reviewed Jan 16, 2021
View reviewed changes
Copy link
Member
@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment from the Conversation.

@SchoolGuy SchoolGuy marked this pull request as ready for review March 5, 2021 07:33
SchoolGuy
SchoolGuy approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member
@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in my eyes. As discussed this can now be merged.

@SchoolGuy
Copy link
Member

@watologo1 There is one failing test. Could you please adjust that!

nodeg
nodeg approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member
@nodeg nodeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the failed test and edited the cobbler-conf.rst file to remove tftpd_py there, too.

@SchoolGuy SchoolGuy merged commit 586f9cf into cobbler:master Mar 5, 2021
@SchoolGuy SchoolGuy deleted the remove_tftp branch March 5, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nodeg nodeg nodeg approved these changes 6242

@SchoolGuy SchoolGuy SchoolGuy approved these changes

@brejoc brejoc Awaiting requested review from brejoc

Assignees

@SchoolGuy SchoolGuy

Labels
tech-debt
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@watologo1 @SchoolGuy @nodeg
0