8000 colexecdisk: extract disk-backed operators into a new package by yuzefovich · Pull Request #80810 · cockroachdb/cockroach · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

colexecdisk: extract disk-backed operators into a new package #80810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2022

Conversation

yuzefovich
Copy link
Member
@yuzefovich yuzefovich commented Apr 29, 2022

colexecdisk: extract disk-backed operators into a new package

This allows us to break dependency of colexec on colexecjoin which
speeds up the build a bit.

Addresses: #79357.

Release note: None

execagg: extract out some aggregate helpers into a separate package

This allows us to break dependency of colexecagg on execinfra.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

This allows us to break dependency of `colexec` on `colexecjoin` which
speeds up the build a bit.

Release note: None
This allows us to break dependency of `colexecagg` on `execinfra`.

Release note: None
@yuzefovich yuzefovich marked this pull request as ready for review May 2, 2022 14:58
@yuzefovich yuzefovich requested a review from a team as a code owner May 2, 2022 14:58
@yuzefovich yuzefovich requested review from msirek and cucaroach May 2, 2022 14:58
Copy link
Contributor
@msirek msirek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @cucaroach)

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

Copy link
Contributor
@cucaroach cucaroach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 28 of 28 files at r1, 19 of 19 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

@craig
Copy link
Contributor
craig bot commented May 2, 2022

Build succeeded:

@craig craig bot merged commit 881d0ec into cockroachdb:master May 2, 2022
@yuzefovich yuzefovich deleted the colexecdisk branch May 2, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0