8000 Added s390x support to Bazel's toolchain by dandotimujahid · Pull Request #80698 · cockroachdb/cockroach · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added s390x support to Bazel's toolchain #80698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2022
Merged

Added s390x support to Bazel's toolchain #80698

merged 1 commit into from
Apr 29, 2022

Conversation

dandotimujahid
Copy link
Contributor
@dandotimujahid dandotimujahid commented Apr 28, 2022 •
edited
Loading

This PR is in reference to the issue #58676
It will enable s390x binaries to be built using Bazel's toolchain

8000
@blathers-crl
Copy link
blathers-crl bot commented Apr 28, 2022

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

Before a member of our team reviews your PR, I have some potential action items for you:

  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

I was unable to automatically find a reviewer. You can try CCing one of the following members:

  • A person you worked with closely on this PR.
  • The person who created the ticket, or a CRDB organization member involved with the ticket (author, commenter, etc.).
  • Join our community slack channel and ask on #contributors.
  • Try find someone else from here.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-untriaged blathers was unable to find an owner labels Apr 28, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl
Copy link
blathers-crl bot commented Apr 28, 2022

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

  • We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

I was unable to automatically find a reviewer. You can try CCing one of the following members:

  • A person you worked with closely on this PR.
  • The person who created the ticket, or a CRDB organization member involved with the ticket (author, commenter, etc.).
  • Join our community slack channel and ask on #contributors.
  • Try find someone else from here.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl
Copy link
blathers-crl bot commented Apr 28, 2022

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

I was unable to automatically find a reviewer. You can try CCing one of the following members:

  • A person you worked with closely on this PR.
  • The person who created the ticket, or a CRDB organization member involved with the ticket (author, commenter, etc.).
  • Join our community slack channel and ask on #contributors.
  • Try find someone else from here.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

rickystewart
rickystewart requested changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator
@rickystewart rickystewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, I just want to make sure the commit message matches up to what we expect. It should look like this:

bazel: add s390x support to Bazel toolchains

Release note: None

The bazel: prefix and the Release note: None bit are of particular importance here.

@blathers-crl
Copy link
blathers-crl bot commented Apr 29, 2022

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@rickystewart
Copy link
Collaborator

Awesome, thanks!

bors r+

@craig
Copy link
Contributor
craig bot commented Apr 29, 2022

Build failed (retrying...):

@craig
Copy link
Contributor
craig bot commented Apr 29, 2022

Build succeeded:

@craig craig bot merged commit 5871a77 into cockroachdb:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickystewart rickystewart rickystewart approved these changes

Assignees
No one assigned
Labels
O-community Originated from the community X-blathers-untriaged blathers was unable to find an owner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dandotimujahid @cockroach-teamcity @rickystewart
0