release: sign MacOS ARM64 binaries #89754
Conversation
|
This change is |
3d64ee6 to
2b4f155
Compare
2b4f155 to
0407b08
Compare
d15f56e to
6df4597
Compare
6df4597 to
2a81219
Compare
|
bors try |
tryBuild succeeded: |
2a81219 to
0989f57
Compare
0989f57 to
3f4772a
Compare
There was a problem hiding this comment.
Code looks good. A couple notes:
- For the epic/issue ref. Can we make it reference
part of #48169orfixes https://github.com/cockroachdb/cockroach/issues/48169since this PR is for that issue? And since the issue links to the epic, we don't need to directly link the epic in the PR either.
| # install bazelisk | ||
| mkdir -p bazelisk-bin | ||
| curl -fsSL https://github.com/bazelbuild/bazelisk/releases/download/v1.13.2/bazelisk-darwin-arm64 > bazelisk-bin/bazel | ||
| shasum --algorithm 256 --check - <<EOF | ||
| c84fb9ae7409b19aee847af4767639ab86fc3ce110f961107ff278879b019e38 bazelisk-bin/bazel | ||
| EOF | ||
| chmod 755 bazelisk-bin/bazel | ||
| export PATH=$PWD/bazelisk-bin:$PATH |
There was a problem hiding this comment.
I'm curious, why install bazelisk on every run instead of installing it on the agent image?
There was a problem hiding this comment.
This agent is a long living one. Installing bazelisk on it would help now, but if we want to use a different version, this would make that installation obsolete.
build/teamcity/internal/cockroach/release/publish/sign_macos_release.sh
Outdated
Show resolved
Hide resolved
3f4772a to
f5a650f
Compare
Previously, released MacOS binaries were uploaded unsigned. This PR adds a new script to sign and upload release binaries. Epic: DEVINF-247 Part of: cockroachdb#48169 Release note: None
f5a650f to
b43cb67
Compare
There was a problem hiding this comment.
LGTM!
Reviewed 5 of 5 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @jlinder and @rail)
|
bors r=jlinder |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from b43cb67 to blathers/backport-release-22.2-89754: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. error creating merge commit from b43cb67 to blathers/backport-release-22.2.0-89754: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.0 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Previously, released MacOS ARM64 binaries were uploaded unsigned.
This PR adds a new script to sign and upload release binaries.
Epic: DEVINF-247
Release note: None