8000 tscache: add intervalSkl metrics by nvanbenschoten · Pull Request #20309 · cockroachdb/cockroach · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

tscache: add intervalSkl metrics #20309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2017
Merged

tscache: add intervalSkl metrics #20309

merged 1 commit into from
Nov 30, 2017

Conversation

nvanbenschoten
Copy link
Contributor
@nvanbenschoten nvanbenschoten commented Nov 28, 2017 •
edited
Loading

These metrics will help us track page count and page rotation rate so
that we can monitor that the tscache remains healthy.

@nvanbenschoten nvanbenschoten requested a review from a team November 28, 2017 19:51
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nvanbenschoten nvanbenschoten force-pushed the nvanbenschoten/tscacheMetrics branch from f0a07a2 to 18d2f6d Compare November 28, 2017 20:54
@nvanbenschoten
tscache: add intervalSkl metrics
33f9cec 
These metrics will help us track page count and page rotation rate so
that we can monitor that the tscache remains healthy.
@nvanbenschoten nvanbenschoten force-pushed the nvanbenschoten/tscacheMetrics branch from 18d2f6d to 33f9cec Compare November 30, 2017 20:30
@nvanbenschoten
Copy link
Contributor Author

Rebased on top of #20232.

@tbg
Copy link
Member
tbg commented Nov 30, 2017

Looks good. I generally wish we'd expose all the metrics that are available somewhere hidden in the ui automatically.

Reviewed 7 of 7 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

pkg/storage/tscache/metrics.go, line 21 at r1 (raw file):

// Metrics holds all metrics relating to a Cache.
type Metrics struct {
	Skl sklImplMetrics

why export Skl?

Comments from Reviewable

@nvanbenschoten
Copy link
Contributor Author

Thanks for the review.

I generally wish we'd expose all the metrics that are available somewhere hidden in the ui automatically.

Do you mean in addition to the /_status/vars page? As graphs?

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

pkg/storage/tscache/metrics.go, line 21 at r1 (raw file):

Previously, tschottdorf (Tobias Schottdorf) wrote…

why export Skl?

It needs to be exported for the reflection-based metrics.Struct magic to work.

Comments from Reviewable

@tbg
Copy link
Member
tbg commented Nov 30, 2017

Yeah, as graphs. Just a random wish, though, for the situations in which we're not looking at our own prometheus-backed clusters.

Btw, that was :lgtm: 😄

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

@nvanbenschoten nvanbenschoten merged commit 911228d into cockroachdb:master Nov 30, 2017
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/tscacheMetrics branch November 30, 2017 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvanbenschoten @cockroach-teamcity @tbg
0