-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thoughts on syntax consistency across languages #29
Comments
I think that consistency is important too. About Vim function, it's my mistake 😅 Vim function is linked to Sending PR or creating issue about inconsistency is welcome :) |
I submitted #32 to fix. |
As I've been trying to normalize the syntax highlighting across several languages, I'm torn on whether or not function invocations should be highlighted. What do you think? To give a concrete example, here is a screenshot of Go code normalized using your guidelines (as I have interpreted them): And here is an alternate version where I experimented with highlighting function invocations and changing variable definitions to green to make them easy to spot: Function invocation highlighting is beneficial when you have a series of function calls within function calls such as: rand.Seed(time.Now().Unix()) From a legibility point of view, it makes it much easier to read code. The only problem is if I use cyan for this function invocation, then there is too much cyan, which require tweaking maybe the color of variable definitions to green perhaps as shown in the alternate version above. I would be very appreciative of your opinion on the matter as it would impact the PR I've submitted. |
As a first step, I re-organized whole highlighting rules in b688907. |
After much thought, I carefully resolved conflicts and merged your changes (#32) to the latest files. In the process, I modified some definitions in terms of consistency:
Feel free to reopen the issue if there are any problems. |
Ah I forgot to reply your suggestion, sorry...
As I said in this comment, at the moment, I think that current highlightings have enough readability so using less colors is better. But I am hesitating about which one is really good. |
Feel free to reopen the issue or create new one if you find new inconsistencies. |
I'm curious to your thoughts about consistency across languages in terms of common syntactic elements. For example, function definitions vim are not highlighted, but they are orange in ruby and go. Yet, internal vim function names are highlighted orange, but in go they are blue. This inconsistency would be easy to fix, but I'm curious if you are opposed to receiving PRs to improve this consistency or whether you don't agree in principle. Thanks!
The text was updated successfully, but these errors were encountered: