feat(cli): add file parameter to verify command #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #280 +/- ##
==========================================
+ Coverage 85.68% 85.70% +0.01%
==========================================
Files 43 43
Lines 5918 5926 +8
==========================================
+ Hits 5071 5079 +8
Misses 847 847
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
"cog verify" can now read the commit message from a file with the "-f" or "--file" parameter. This parameter is mutually exclusive with the "message" argument. implement cocogitto#279
1fe9a43 to
b6c9b3b
Compare
|
Hey @sebasnabas thanks for the PR! |
Details can be seen in clap-rs/clap#4733. Using Subcommand with old clap versions causes clippy 1.69 to complain. In this case it was: ``` error: this looks like you are trying to swap `arg` and `cmd` --> src/bin/cog/main.rs:292:23 ```
|
@oknozor Just did! I had to bump clap as well (See clap-rs/clap#4733) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"cog verify" can now read the commit message from a file with the "-f" or "--file" parameter. This parameter is mutually exclusive with the "message" argument.
implement #279