8000 feat: add from_latest_tag to settings by stephenc · Pull Request #234 · cocogitto/cocogitto · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add from_latest_tag to settings #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2022
Merged

feat: add from_latest_tag to settings #234

merged 1 commit into from
Oct 28, 2022

Conversation

stephenc
Copy link
Contributor
@stephenc stephenc commented Oct 27, 2022 •
edited
Loading

Without the ability to specify the from_latest_tag in the settings file it is very difficult to add cocogitto to an existing repository as you need to do one of the following:

  • remember to only run cog install-hook commit-msg otherwise your pushes can fail depending on the local and remote states
  • or manually edit the hooks, defeating the nice ux of the cog install-hook command

@oknozor
Copy link
Collaborator
oknozor commented Oct 27, 2022

Hey @stephenc Thanks for the PR!
We just updated to clap 4.0, can you fix the conflict so we can merge this ?

@stephenc stephenc force-pushed the settings-from_latest_tag branch from 05186f0 to d716a0e Compare October 27, 2022 13:33
@cocogitto-bot
Copy link
cocogitto-bot bot commented Oct 27, 2022

✔️ d716a0e - Conventional commits check succeeded.

@stephenc
Copy link
Contributor Author

@oknozor I've rebased the change, but it was unaffected as it only touches the settings file and how those default in

@stephenc
Copy link
Contributor Author

FYI: the tests seem to assume that git is configured to use master as the default initial branch... so I currently have two failing on my machine as I set up my git install to default to main for new repos

@stephenc
Copy link
Contributor Author

#235 added to note the test failure issue

@codecov
Copy link
codecov bot commented Oct 27, 2022

Codecov Report

Merging #234 (d716a0e) into main (dbef47b) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
- Coverage   82.78%   82.77%   -0.02%     
==========================================
  Files          30       30              
  Lines        3916     3918       +2     
==========================================
+ Hits         3242     3243       +1     
- Misses        674      675       +1
Impacted Files Coverage Δ
src/settings/mod.rs 98.07% <ø> (ø)
src/bin/cog/main.rs 55.02% <50.00%> (-0.05%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oknozor oknozor merged commit a154782 into cocogitto:main Oct 28, 2022
@stephenc stephenc deleted the settings-from_latest_tag branch October 28, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenc @oknozor
0