fix(args): mutually exclusive hook and all #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the "all" argument doesn't do anything in hook mode, we might as well just make them mutually exclusive for more clarity.
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
Merged
cococonscious
added a commit
that referenced
this pull request
Jan 6, 2025
## 🤖 New release * `koji`: 3.0.0 -> 3.1.0 ###⚠️ `koji` breaking changes (irrelevant for users) ``` --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/constructible_struct_adds_field.ron Failed in: field Config.workdir in /tmp/.tmp0qUV6w/koji/src/lib/config.rs:17 --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/function_missing.ron Failed in: function koji::questions::prompt_issue_text, previously in file /tmp/.tmpGSN8WR/koji/src/lib/questions.rs:243 function koji::questions::prompt_issues, previously in file /tmp/.tmpGSN8WR/koji/src/lib/questions.rs:233 function koji::questions::prompt_scope, previously in file /tmp/.tmpGSN8WR/koji/src/lib/questions.rs:114 function koji::questions::prompt_type, previously in file /tmp/.tmpGSN8WR/koji/src/lib/questions.rs:98 function koji::questions::prompt_breaking, previously in file /tmp/.tmpGSN8WR/koji/src/lib/questions.rs:204 function koji::questions::prompt_body, previously in file /tmp/.tmpGSN8WR/koji/src/lib/questions.rs:185 function koji::questions::prompt_summary, previously in file /tmp/.tmpGSN8WR/koji/src/lib/questions.rs:169 function koji::questions::prompt_breaking_text, previously in file /tmp/.tmpGSN8WR/koji/src/lib/questions.rs:214 --- failure function_parameter_count_changed: pub fn parameter count changed --- Description: A publicly-visible function now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/function_parameter_count_changed.ron Failed in: koji::commit::commit now takes 2 parameters instead of 1, in /tmp/.tmp0qUV6w/koji/src/lib/commit.rs:35 koji::answers::get_extracted_answers now takes 3 parameters instead of 2, in /tmp/.tmp0qUV6w/koji/src/lib/answers.rs:66 ``` <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [3.1.0](v3.0.0...v3.1.0) - 2025-01-06 ### Added - git-like -C argument, integration tests (#103) ### Changed - *(deps)* update codecov/codecov-action action to v5.1.2 (#123, #116) - *(deps)* update all non-major dependencies (#122, #112) - *(deps)* update rust crate serde to v1.0.216 (#119) - *(deps)* update actions/cache action to v4.2.0 (#113) ### Fixed - *(args)* mutually exclusive hook and all (#121) - *(config)* handled better using config-rs (#120) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Finley Thomalla <finley@thomalla.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the "all" argument doesn't do anything in hook mode, we might as well just make them mutually exclusive for more clarity.