8000 test: fix lint by fengmk2 · Pull Request #813 · cnpm/cnpmcore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test: fix lint #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related e 8000 mails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

test: fix lint #813

merged 1 commit into from
Jun 20, 2025

Conversation

fengmk2
Copy link
Member
@fengmk2 fengmk2 commented Jun 20, 2025 •
edited by coderabbitai bot
Loading

PR Dependency Tree

This tree was auto-generated by Charcoal

Summary by CodeRabbit

  • Chores
    • Updated linting configuration to explicitly allow import extensions.

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jun 20, 2025 •
edited
Loading 8000

Walkthrough

A configuration update was made to the .oxlintrc.json file, specifically adding the "import/extensions" rule with the value "allow" under the "import" rules section. No changes were made to code or exported entities.

Changes

File(s) Change Summary
.oxlintrc.json Added "import/extensions" rule with value "allow".

Poem

In the warren of code, a rule now appears,
Imports with extensions can hop without fears.
The linter’s new wisdom, a gentle decree—
"Extensions are welcome!" it chirps with glee.
So code on, dear devs, let your imports be free!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e4cd535 and 7361241.

📒 Files selected for processing (1)
  • .oxlintrc.json (1 hunks)
🧰 Additional context used
🪛 Biome (1.9.4)
.oxlintrc.json

[error] 81-81: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

[error] 81-81: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

[error] 81-81: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

[error] 81-83: End of file expected

Use an array for a sequence of values: [1, 2]

(parse)

⏰ Context from checks skipped due to timeout of 90000ms (9)
  • GitHub Check: Trag Review
  • GitHub Check: test-mysql57-s3-nfs (22, ubuntu-latest)
  • GitHub Check: test-mysql57-fs-nfs (22, ubuntu-latest)
  • GitHub Check: test-mysql57-fs-nfs (24, ubuntu-latest)
  • GitHub Check: test-mysql57-fs-nfs (20, ubuntu-latest)
  • GitHub Check: test-mysql57-s3-nfs (20, ubuntu-latest)
  • GitHub Check: test-postgresql-fs-nfs (24, ubuntu-latest)
  • GitHub Check: test-postgresql-fs-nfs (20, ubuntu-latest)
  • GitHub Check: test-postgresql-fs-nfs (22, ubuntu-latest)
🔇 Additional comments (1)
.oxlintrc.json (1)

81-81: Allow import/extensions rule to pass
Setting "import/extensions": "allow" correctly disables enforcement of file‐extension checks in imports, resolving related lint failures.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fengmk2 fengmk2 enabled auto-merge (squash) June 20, 2025 06:54
@fengmk2 fengmk2 requested review from Copilot and elrrrrrrr June 20, 2025 06:54
Copilot
Copilot AI reviewed Jun 20, 2025
View reviewed changes
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables auto merge functionality by updating the CI configuration.

  • Added an empty "merge_group:" key in the nodejs workflow configuration.
Comments suppressed due to low confidence (1)

.github/workflows/nodejs.yml:11

  • [nitpick] Consider adding a comment to explain the purpose of the 'merge_group:' field and clarify any expected values to improve maintainability.
  merge_group:

@fengmk2 fengmk2 requested a review from killagu June 20, 2025 06:54
@fengmk2 fengmk2 force-pushed the enable-auto-merge branch from 52c0f7a to cbb2af9 Compare June 20, 2025 06:58
@codecov Codecov
Copy link
codecov bot commented Jun 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.34%. Comparing base (e932624) to head (7361241).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #813   +/-   ##
=======================================
  Coverage   95.34%   95.34%           
=======================================
  Files         196      196           
  Lines       23686    23686           
  Branches     2157     2164    +7     
=======================================
  Hits        22583    22583           
  Misses       1103     1103

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fengmk2 fengmk2 force-pushed the enable-auto-merge branch from cbb2af9 to 7361241 Compare June 20, 2025 07:34
@fengmk2 fengmk2 changed the title chore: enable auto merge test: fix lint Jun 20, 2025
@trag-bot Trag bot
Copy link
trag-bot bot commented Jun 20, 2025

Pull request summary

  • Added a new ESLint rule to allow file extensions in import statements.
  • Updated the .oxlintrc.json configuration file to include the import/extensions rule.
  • Ensured that the new rule does not conflict with existing import/export rules.

@fengmk2 fengmk2 added this pull request to the merge queue Jun 20, 2025
Merged via the queue into master with commit 5b96443 Jun 20, 2025
14 checks passed
@fengmk2 fengmk2 deleted the enable-auto-merge branch June 20, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@elrrrrrrr elrrrrrrr elrrrrrrr approved these changes

@killagu killagu Awaiting requested review from killagu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

34DA
2 participants
@fengmk2 @elrrrrrrr
0