Push latest tag on tag builds #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheton
approved these changes
Oct 4, 2022
0788efa to
044ccbf
Compare
|
@cheton should we also be publishing |
|
I'll merge this and patch release for now so we can get something in the latest tag. |
|
Workflow failed, I messed up the tagging, investigating. https://app.circleci.com/pipelines/github/cncjs/cncjs/237/workflows/8ff05004-b348-4103-a148-47c91f099bc6/jobs/405 |
Merged
cheton
pushed a commit
that referenced
this pull request
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I considered attempting to restrict this to
masterbranch builds only, but it appears that$CIRCLE_BRANCHis empty during thedeploy-tagjob. Looks like if it's a tag build, then$CIRCLE_TAGis populated instead. I inspected this run.Tag builds should be safe to tag as
latest, I think.Resolves #741