Possible fix to XP per kill rounding/truncation issue #740
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The multiplication step '(ownerlevel * 5 + nBaseExp) * BaseGainLevelFactor()' produces a 'float' value, but since the return type of 'BaseGain' is 'uint32', the compiler implicitly truncates the XP value when converting from 'float' to 'uint32'. By changing the return type of 'BaseGain' from 'uint32' to 'float', this preserves the fractional XP value until the very end, when the XP value is converted to an integer using 'std:nearbyint()'. I did very limited testing, but killing a Level 3 mob as Level 2 player did, in fact, yield '58' rather than '57' XP.
|
Nice one. Ty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multiplication steps
return nBaseExp * (1.0f + (0.05f * nLevelDiff));andreturn nBaseExp * (1.0f - (float(nLevelDiff) / ZD));producefloatvalues, but since the return type ofBaseGainisuint32, the compiler implicitly truncates the XP value when converting fromfloattouint32.By changing the return type of
BaseGainfromuint32tofloat, this preserves the fractional XP value until the very end, when the XP value is converted to an integer usingstd:nearbyint().I did very limited testing, but, for example, killing a Level 3 mob as Level 2 player did, in fact, yield
58rather than57XP after this change, as intended (I observed on official Blizzard realms that XP per kill is always 8000 rounded up rather than truncated/rounded down).This conversation was originally had over in VMaNGOS, where I proposed a similar change. I observed the same behaviour in CMaNGOS.
I, in no way, pretend to be an expert, and I'm happy to be educated in a different direction if this change is flawed in some way.