8000 [WIP] optimize(gRPC): do not log when there is no active gRPC connection in graceful shutdown phase by DMwangnima · Pull Request #1785 · cloudwego/kitex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[WIP] optimize(gRPC): do not log when there is no active gRPC connection in graceful shutdown phase #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[WIP] optimize(gRPC): do not log when there is no active gRPC connection in graceful shutdown phase #1785

wants to merge 1 commit into from

Conversation

DMwangnima
Copy link
Contributor

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@DMwangnima DMwangnima requested review from a team as code owners June 3, 2025 06:36
@codecov Codecov
Copy link
codecov bot commented Jun 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.97%. Comparing base (b36d010) to head (baaa9a4).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1785      +/-   ##
===========================================
+ Coverage    59.94%   59.97%   +0.03%     
===========================================
  Files          381      381              
  Lines        34660    34664       +4     
===========================================
+ Hits         20778    20791      +13     
+ Misses       12621    12612       -9     
  Partials      1261     1261
Flag Coverage Δ
integration 48.13% <100.00%> (+<0.01%) ⬆️
unit 50.36% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DMwangnima DMwangnima force-pushed the optimize/grpc_graceful_shutdown_log branch from 73540d9 to baaa9a4 Compare June 6, 2025 03:12
@DMwangnima DMwangnima changed the title optimize(gRPC): do not log when there is no active gRPC connection in graceful shutdown phase [WIP] optimize(gRPC): do not log when there is no active gRPC connection in graceful shutdown phase Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DMwangnima
0