8000 optimize(ttstream): log the error thrown by invoking handler by DMwangnima · Pull Request #1780 · cloudwego/kitex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

optimize(ttstream): log the error thrown by invoking handler #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

optimize(ttstream): log the error thrown by invoking handler #1780

merged 1 commit into from
May 29, 2025

Conversation

DMwangnima
Copy link
Contributor

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

feat(ttstream): 为 invoking handler 中抛出的错误打日志

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):
对于 ttstream，当前若 invoking handler 抛出错误(特别是发生 panic)，server 侧并不会向其它协议一样打出日志以及相应堆栈，难以排查问题。

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@DMwangnima DMwangnima requested review from a team as code owners May 27, 2025 07:33
@DMwangnima DMwangnima force-pushed the feat/ttstream_log_stack branch from d5091c9 to 1393404 Compare May 28, 2025 05:25
@DMwangnima DMwangnima marked this pull request as draft May 28, 2025 05:26
@DMwangnima DMwangnima force-pushed the feat/ttstream_log_stack branch 3 times, most recently from ee0b880 to 8ff9f9b Compare May 28, 2025 08:39
@codecov Codecov
Copy link
codecov bot commented May 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 59.94%. Comparing base (c5d41fa) to head (f17f15e).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
pkg/remote/trans/ttstream/server_handler.go 66.66% 5 Missing and 1 partial ⚠️
internal/mocks/remote/servicesearcher.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1780      +/-   ##
===========================================
+ Coverage    59.82%   59.94%   +0.12%     
===========================================
  Files          381      381              
  Lines        34617    34626       +9     
===========================================
+ Hits         20710    20758      +48     
+ Misses       12651    12616      -35     
+ Partials      1256     1252       -4
Flag Coverage Δ
integration 48.04% <27.77%> (-0.03%) ⬇️
unit 50.46% <63.15%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DMwangnima DMwangnima force-pushed the feat/ttstream_log_stack branch from 8ff9f9b to 18514fd Compare May 28, 2025 08:45
@DMwangnima DMwangnima changed the title feat(ttstream): log the error thrown by invoking handler optimize(ttstream): log the error thrown by invoking handler May 28, 2025
@DMwangnima DMwangnima force-pushed the feat/ttstream_log_stack branch from 18514fd to f17f15e Compare May 28, 2025 08:52
@DMwangnima DMwangnima marked this pull request as ready for review May 28, 2025 08:55
@DMwangnima DMwangnima merged commit 8124ee3 into cloudwego:develop May 29, 2025
22 checks passed
@DMwangnima DMwangnima deleted the feat/ttstream_log_stack branch May 29, 2025 02:28
HeyJavaBean pushed a commit to HeyJavaBean/kitex that referenced this pull request Jun 10, 2025
@DMwangnima @HeyJavaBean
optimize(ttstream): log the error thrown by invoking handler (cloudwe…
f678789 
…go#1780)
@BrewTestBot BrewTestBot mentioned this pull request Jun 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joway joway joway approved these changes

@jayantxie jayantxie jayantxie approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DMwangnima @joway @jayantxie
0