8000 feat(client): report err when create Stream failed by XinyiWang0204 · Pull Request #1777 · cloudwego/kitex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fe 8000 at(client): report err when create Stream failed #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 27, 2025
Merged

feat(client): report err when create Stream failed #1777

merged 5 commits into from
May 27, 2025

Conversation

XinyiWang0204
Copy link
Contributor

What type of PR is this?

feat: add DoFinish trace for stream error handling

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@XinyiWang0204 XinyiWang0204 requested review from a team as code owners May 20, 2025 03:25
@DMwangnima DMwangnima self-assigned this May 20, 2025
@codecov Codecov
Copy link
codecov bot commented May 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 56.25000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 59.79%. Comparing base (7c4ae57) to head (2dd0e49).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
client/stream.go 56.25% 12 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1777      +/-   ##
===========================================
- Coverage    59.81%   59.79%   -0.03%     
===========================================
  Files          382      382              
  Lines        34594    34622      +28     
===========================================
+ Hits         20693    20702       +9     
- Misses       12642    12657      +15     
- Partials      1259     1263       +4
Flag Coverage Δ
integration 47.97% <25.00%> (-0.10%) ⬇️
unit 50.04% <56.25%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

DMwangnima
DMwangnima reviewed May 20, 2025
View reviewed changes
jayantxie
jayantxie previously approved these changes May 27, 2025
View reviewed changes
DMwangnima
DMwangnima reviewed May 27, 2025
View reviewed changes
@DMwangnima DMwangnima changed the title Feat/stream dofinish trace feat(client): report err when create Stream failed May 27, 2025
@DMwangnima DMwangnima merged commit 7a3b4e9 into cloudwego:develop May 27, 2025
20 of 22 checks passed
@XinyiWang0204 XinyiWang0204 deleted the feat/stream-dofinish-trace branch June 4, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayantxie jayantxie jayantxie approved these changes

@DMwangnima DMwangnima DMwangnima approved these changes

Assignees

@DMwangnima DMwangnima

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XinyiWang0204 @jayantxie @DMwangnima
0