cloudposse · osterman · Mar 7, 2025 · Mar 6, 2025 · Mar 6, 2025 · Mar 6, 2025
@@ -1,15 +1,9 @@
 package cmd
 
 import (
-	"fmt"
-	"runtime"
-	"strings"
-
 	"github.com/spf13/cobra"
 
-	tuiUtils "github.com/cloudposse/atmos/internal/tui/utils"
-	u "github.com/cloudposse/atmos/pkg/utils"
-	"github.com/cloudposse/atmos/pkg/version"
+	"github.com/cloudposse/atmos/internal/exec"
 )
 
 var checkFlag bool
@@ -21,42 +15,7 @@
 	Example: "atmos version",
 	Args:    cobra.NoArgs,
 	Run: func(cmd *cobra.Command, args []string) {
-		// Print a styled Atmos logo to the terminal
-		fmt.Println()
-		err := tuiUtils.PrintStyledText("ATMOS")
-		if err != nil {
-			u.LogErrorAndExit(err)
-		}
-
-		atmosIcon := "\U0001F47D"
-
-		u.PrintMessage(fmt.Sprintf("%s Atmos %s on %s/%s", atmosIcon, version.Version, runtime.GOOS, runtime.GOARCH))
-		fmt.Println()
-
-		if checkFlag {
-			// Check for the latest Atmos release on GitHub
-			latestReleaseTag, err := u.GetLatestGitHubRepoRelease("cloudposse", "atmos")
-			if err == nil && latestReleaseTag != "" {
-				if err != nil {
-					u.LogWarning(fmt.Sprintf("Failed to check for updates: %v", err))
-					return
-				}
-				if latestReleaseTag == "" {
-					u.LogWarning("No release information available")
-					return
-				}
-				latestRelease := strings.TrimPrefix(latestReleaseTag, "v")
-				currentRelease := strings.TrimPrefix(version.Version, "v")
-
-				if latestRelease == currentRelease {
-					u.PrintMessage(fmt.Sprintf("You are running the latest version of Atmos (%s)", latestRelease))
-				} else {
-					u.PrintMessageToUpgradeToAtmosLatestRelease(latestRelease)
-				}
-			}
-			return
-		}
-
+		exec.NewVersionExec().Execute(checkFlag)
 		// Check for the cache and print update message
 		CheckForAtmosUpdateAndPrintMessage(atmosConfig)
 	},

@@ -0,0 +1,65 @@
+package exec
+
+import (
+	"fmt"
+	"runtime"
+	"strings"
+
+	log "github.com/charmbracelet/log"
+	tuiUtils "github.com/cloudposse/atmos/internal/tui/utils"
+	u "github.com/cloudposse/atmos/pkg/utils"
+
+	"github.com/cloudposse/atmos/pkg/version"
+)
+
+type versionExec struct {
+	printStyledText                           func(string) error
+	getLatestGitHubRepoRelease                func(string, string) (string, error)
+	printMessage                              func(string)
+	printMessageToUpgradeToAtmosLatestRelease func(string)
+}
+
+func NewVersionExec() *versionExec {
+	return &versionExec{
+		printStyledText:                           tuiUtils.PrintStyledText,
+		getLatestGitHubRepoRelease:                u.GetLatestGitHubRepoRelease,
+		printMessage:                              u.PrintMessage,
+		printMessageToUpgradeToAtmosLatestRelease: u.PrintMessageToUpgradeToAtmosLatestRelease,
+	}
+}
+
+func (v versionExec) Execute(checkFlag bool) {
+	// Print a styled Atmos logo to the terminal
+	v.printMessage("")
+	err := v.printStyledText("ATMOS")
+	if err != nil {
+		//nolint:revive
+		log.Fatal(err)
+	}
+
+	atmosIcon := "\U0001F47D"
+
+	v.printMessage(fmt.Sprintf("%s Atmos %s on %s/%s", atmosIcon, version.Version, runtime.GOOS, runtime.GOARCH))
+	v.printMessage("")
+
+	if checkFlag {
+		v.checkRelease()
+	}
+}
+
+func (v versionExec) checkRelease() {
+	// Check for the latest Atmos release on GitHub
+	latestReleaseTag, err := v.getLatestGitHubRepoRelease("cloudposse", "atmos")
+	if err != nil || latestReleaseTag == "" {
+		log.Debug("Did not get release tag", "err", err, "latestReleaseTag", latestReleaseTag)
+		return
+	}
+	latestRelease := strings.TrimPrefix(latestReleaseTag, "v")
+	currentRelease := strings.TrimPrefix(version.Version, "v")
+
+	if latestRelease == currentRelease {
+		log.Info("You are running the latest version of Atmos", "version", latestRelease)
+	} else {
+		v.printMessageToUpgradeToAtmosLatestRelease(latestRelease)
+	}
+}
@@ -0,0 +1,103 @@
+package exec
+
+import (
+	"testing"
+
+	"github.com/cloudposse/atmos/pkg/version"
+	"github.com/golang/mock/gomock"
+	"github.com/pkg/errors"
+)
+
+// Mock interfaces generated by mockgen
+// VersionExecutor defines the interface for version execution operations
+//
+//go:generate mockgen -source=$GOFILE -destination=mock_$GOFILE -package=$GOPACKAGE
+type VersionExecutor interface {
+	PrintStyledText(text string) error
+	GetLatestGitHubRepoRelease(owner, repo string) (string, error)
+	PrintMessage(message string)
+	PrintMessageToUpgradeToAtmosLatestRelease(version string)
+}
+
+func TestVersionExec_Execute(t *testing.T) {
+	// Save original values
+	originalVersion := version.Version
+	defer func() { version.Version = originalVersion }()
+
+	tests := []struct {
+		name                string
+		checkFlag           bool
+		version             string
+		latestRelease       string
+		printStyledTextErr  error
+		getLatestReleaseErr error
+	}{
+		{
+			name:      "Basic execution without check",
+			checkFlag: false,
+			version:   "v1.0.0",
+		},
+		{
+			name:          "Check flag with same version",
+			checkFlag:     true,
+			version:       "v1.0.0",
+			latestRelease: "v1.0.0",
+		},
+		{
+			name:          "Check flag with different version",
+			checkFlag:     true,
+			version:       "v1.0.0",
+			latestRelease: "v1.1.0",
+		},
+		{
+			name:                "Check flag with release check error",
+			checkFlag:           true,
+			version:             "v1.0.0",
+			getLatestReleaseErr: errors.New("github error"),
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			// Setup mock controller
+			ctrl := gomock.NewController(t)
+			defer ctrl.Finish()
+
+			// Create mocks
+			mockExec := NewMockVersionExecutor(ctrl)
+
+			// Set version
+			version.Version = tt.version
+
+			// Setup mock expectations
+			mockExec.EXPECT().PrintStyledText("ATMOS").Return(tt.printStyledTextErr)
+			//nolint:nestif
+			if tt.printStyledTextErr == nil {
+				mockExec.EXPECT().PrintMessage(gomock.Any()).Times(3)
+
+				if tt.checkFlag {
+					mockExec.EXPECT().GetLatestGitHubRepoRelease("cloudposse", "atmos").
+						Return(tt.latestRelease, tt.getLatestReleaseErr)
+
+					if tt.getLatestReleaseErr == nil && tt.latestRelease != "" {
+						if tt.latestRelease != tt.version {
+							mockExec.EXPECT().PrintMessageToUpgradeToAtmosLatestRelease(
+								gomock.Eq(tt.latestRelease[1:])).Times(1)
+						}
+					}
+				}
+			}
+
+			// Create test instance with mocks
+			v := versionExec{
+				printStyledText:                           mockExec.PrintStyledText,
+				getLatestGitHubRepoRelease:                mockExec.GetLatestGitHubRepoRelease,
+				printMessage:                              mockExec.PrintMessage,
+				printMessageToUpgradeToAtmosLatestRelease: mockExec.PrintMessageToUpgradeToAtmosLatestRelease,
+			}
+
+			// Execute the function
+			v.Execute(tt.checkFlag)
+		})
+	}
+}
@@ -3,8 +3,8 @@
 import (
 	"context"
 	"os"
-	"time"
 
+	log "github.com/charmbracelet/log"
 	"github.com/google/go-github/v59/github"
 	"golang.org/x/oauth2"
 )
@@ -26,25 +26,23 @@
 	return github.NewClient(tc)
 }
 <
C4D6
/span>
-// GetLatestGitHubRepoRelease returns the latest release tag for a GitHub repository
+// GetLatestGitHubRepoRelease returns the latest release tag for a GitHub repository.
 func GetLatestGitHubRepoRelease(owner string, repo string) (string, error) {
-	opt := &github.ListOptions{Page: 1, PerPage: 1}
-
-	ctx, cancel := context.WithTimeout(context.Background(), time.Second*2)
-	defer cancel()
+	log.Debug("Fetching latest release from Github API", "owner", owner, "repo", repo)
 
+	// Create a new GitHub client with authentication if available
+	ctx := context.Background()
 	client := newGitHubClient(ctx)
 
-	releases, _, err := client.Repositories.ListReleases(ctx, owner, repo, opt)
+	// Get the latest release
+	release, _, err := client.Repositories.GetLatestRelease(ctx, owner, repo)
 	if err != nil {
 		return "", err
 	}
 
-	if len(releases) > 0 {
-		latestRelease := releases[0]
-		latestReleaseTag := *latestRelease.TagName
-		return latestReleaseTag, nil
+	if release == nil || release.TagName == nil {
+		return "", nil
 	}
 
-	return "", nil
+	return *release.TagName, nil
 }