8000 fix(pluginpresets): clusteroverrides are not considered during admission by Zaggy21 · Pull Request #967 · cloudoperators/greenhouse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(pluginpresets): clusteroverrides are not considered during admission #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 12, 2025
Merged

fix(pluginpresets): clusteroverrides are not considered during admission #967

merged 13 commits into from
Mar 12, 2025

Conversation

Zaggy21
Copy link
Contributor
@Zaggy21 Zaggy21 commented Mar 5, 2025

Description

This PR removes the validation of required option values for PluginPreset creation, leaving it for the Plugin validation. Errors that occur at the Plugin creation during PluginPreset reconciliation are saved to the PluginFailed condition in the PluginPreset resource.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Added integration tests verifying that PluginPresetController:

  • can create a Plugin with required options taken from PluginPreset overrides,
  • saves an error when Plugin creation failed due to required options being unset.

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@Zaggy21 Zaggy21 requested a review from a team as a code owner March 5, 2025 16:02
@Zaggy21 Zaggy21 linked an issue Mar 5, 2025 that may be closed by this pull request
🐛 [BUG] - PluginPreset ClusterOverrides are not considered during admission #942
Closed
2 tasks
IvoGoman
IvoGoman requested changes Mar 5, 2025
View reviewed changes
@Zaggy21 Zaggy21 requested a review from IvoGoman March 7, 2025 17:38
k.zagorski added 2 commits March 11, 2025 15:02
IvoGoman
IvoGoman requested changes Mar 12, 2025
View reviewed changes
@Zaggy21 @IvoGoman
remove unnecessary check
57b4ba0 
Co-authored-by: IvoGoman <ivo.gosemann@sap.com>
@Zaggy21 Zaggy21 merged commit 0b10b38 into main Mar 12, 2025
22 checks passed
@Zaggy21 Zaggy21 deleted the fix/pluginpreset-clusteroverrides-are-not-considered-during-admission branch March 12, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvoGoman IvoGoman IvoGoman approved these changes

Assignees
No one assigned
Labels
core-apis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - PluginPreset ClusterOverrides are not considered during admission
2 participants
@Zaggy21 @IvoGoman
0