8000 fix(ci): no windows binaries in release by kengou · Pull Request #924 · cloudoperators/greenhouse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(ci): no windows binaries in release #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2025
Merged

fix(ci): no windows binaries in release #924

merged 2 commits into from
Feb 21, 2025
+32 −44

Conversation

kengou
Copy link
Contributor
@kengou kengou commented Feb 21, 2025

Description

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@kengou kengou requested a review from a team as a code owner February 21, 2025 12:15
@kengou kengou changed the title fix(ci) do not build windows for now fix(ci): do not build windows binaries Feb 21, 2025
@kengou kengou changed the title fix(ci): do not build windows binaries fix(ci): no windows binaries in release Feb 21, 2025
IvoGoman
IvoGoman previously approved these changes Feb 21, 2025
View reviewed changes
@kengou kengou merged commit 5bb0642 into main Feb 21, 2025
8 checks passed
@kengou kengou deleted the fix/gorleleaser branch February 21, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvoGoman IvoGoman Awaiting requested review from IvoGoman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kengou @IvoGoman @abhijith-darshan
0