8000 Feature/folder structure strategy by lukma99 · Pull Request #26 · cloudogu/gitops-build-lib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature/folder structure strategy #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Mar 10, 2023
Merged

Feature/folder structure strategy #26

merged 22 commits into from
Mar 10, 2023

Conversation

lukma99
Copy link
Contributor
@lukma99 lukma99 commented Mar 8, 2023

Changelog:

  • Bump default cesBuildLib version to 1.62.0
  • Bump default kubectl image to 'lachlanevenson/k8s-kubectl:v1.24.8'
  • Bump default helm image to 'ghcr.io/cloudogu/helm:3.11.1-2'
  • Disable kubeval and helm kubeval in default config, because they are deprecated (we will introduce another linting tool later)
  • Support different base path in destination gitops repository with destinationRootPath
  • Support different folder strategies with folderStructureStrategy
  • Fix bug where build lib crashes when supplying buildImages images as strings as instead of maps
  • Remove dummy kubeconfig when running kubectl ... --dry-run=client, as dry-runs also work without a context

lukma99 and others added 15 commits March 6, 2023 09:32
@lukma99
bump versions of kubectl, helm and cesBuildLib
ef676df
@lukma99
Add new parameters folderStructureStrategy and destinationRootPath to…
a66d527 
… config for build lib, which can be used to modify the deployment path for manifests in the destination repository.
@lukma99
add print for gitops config to see result temporarily
abc2d4f
@lukma99
potential fix for bug, where strings as imageConfigs do not work.
136ca2f
@lukma99
potential fix for bug, where strings as imageConfigs do not work.
492bbd6
@lukma99
add validation for folderStructureStrategy
63c7b51
@lukma99
fix typo
7c5c3b1
@lukma99
fix error in validation
baa7370
@lukma99
fix error in validation
7ae5eed
@lukma99
Merge remote-tracking branch 'origin/feature/folder_structure_strateg…
57c7e0d 
…y' into feature/folder_structure_strategy

# Conflicts:
#	vars/deployViaGitops.groovy
@lukma99
remove debug print
c129806
@lukma99
add information about new features for folder structure strategy in R…
b04f317 
…eadme.md
@lukma99
appen table of contents in Readme.md
c98648c
@lukma99
remove dummy kubeconfig method, as it is not nesecarry to create dry-…
f6d1fa6 
…runs
@lukma99
Update README.md
3b4532a
@lukma99 lukma99 self-assigned this Mar 8, 2023
@schnatterer
DeployViaGitopsTest: Make sure tests are run.
969ae00 
And fix tests.

Most asserts never ran, because the tests arrive at deploy() function because the execution stopped after validating parameters (invalid parameters).

Also: There no longer seem to be default stages! Remove tests and updated README.
@schnatterer
Update dependencies
7154e10 
Groovy Version used in Jenkins 2.375.2
@schnatterer schnatterer mentioned this pull request Mar 8, 2023
Open
@schnatterer schnatterer force-pushed the feature/folder_structure_strategy branch from ec7fdd7 to 5dc4d78 Compare March 8, 2023 17:05
@schnatterer
Make better use of enums
4916dfe 
Simplify code, add test for invalid params, fail early on invalid GitOps tools
@schnatterer schnatterer force-pushed the feature/folder_structure_strategy branch from 5dc4d78 to 4916dfe Compare March 9, 2023 07:51
@schnatterer schnatterer merged commit 1640120 into main Mar 10, 2023
@schnatterer schnatterer deleted the feature/folder_structure_strategy branch March 10, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lukma99 lukma99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukma99 @schnatterer
0