8000 feat: Add `WorkflowRetentionDuration` to `WorkflowInstanceCreateOptions` by Caio-Nogueira · Pull Request #4074 · cloudflare/workerd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Add WorkflowRetentionDuration to WorkflowInstanceCreateOptions #4074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

feat: Add WorkflowRetentionDuration to WorkflowInstanceCreateOptions #4074

merged 1 commit into from
May 30, 2025
+130 −0

Conversation

Caio-Nogueira
Copy link
Contributor

Related to WOR-638

We need to expose InstanceRetention as an additional field to WorkflowInstanceCreateOptions, thus allowing custom retention periods through binding-shim.

@Caio-Nogueira Caio-Nogueira requested a review from a tea 10000 m as a code owner May 2, 2025 13:58
@Caio-Nogueira Caio-Nogueira force-pushed the caio/workflows-custom-retention branch from 594f543 to b1e6b2d Compare May 2, 2025 13:58
@Caio-Nogueira Caio-Nogueira requested a review from LuisDuarte1 May 2, 2025 13:59
@Caio-Nogueira Caio-Nogueira force-pushed the caio/workflows-custom-retention branch from b1e6b2d to 05b9bee Compare May 2, 2025 14:03
dario-piotrowicz
dario-piotrowicz approved these changes May 2, 2025
View reviewed changes
@Caio-Nogueira Caio-Nogueira force-pushed the caio/workflows-custom-retention branch from 05b9bee to c2699d8 Compare May 5, 2025 10:05
@github-actions GitHub Actions
Copy link
github-actions bot commented May 5, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@github-actions GitHub Actions
Copy link
github-actions bot commented May 5, 2025 •
edited
Loading

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

LuisDuarte1
LuisDuarte1 approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor
@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from the workflows team

@Caio-Nogueira Caio-Nogueira force-pushed the caio/workflows-custom-retention branch 2 times, most recently from 70f5e58 to 9ee6e2d Compare May 22, 2025 13:53
@Caio-Nogueira Caio-Nogueira force-pushed the caio/workflows-custom-retention branch from 9ee6e2d to f935636 Compare May 22, 2025 14:40
@Caio-Nogueira Caio-Nogueira requested review from a team as code owners May 22, 2025 14:40
@Caio-Nogueira
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request May 22, 2025
@github-actions
@Caio-Nogueira has signed the CLA in #4074
b4b2bf2
@Caio-Nogueira Caio-Nogueira merged commit e08c16b into main May 30, 2025
18 checks passed
@Caio-Nogueira Caio-Nogueira deleted the caio/workflows-custom-retention branch May 30, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

@danlapid danlapid danlapid approved these changes

@LuisDuarte1 LuisDuarte1 LuisDuarte1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Caio-Nogueira @danlapid @LuisDuarte1 @dario-piotrowicz
0