8000 Expose tag and attribute names with the original case. by orium · Pull Request #190 · cloudflare/lol-html · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Expose tag and attribute names with the original case. #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2023
Merged

Expose tag and attribute names with the original case. #190

merged 3 commits into from
Jul 28, 2023

Conversation

orium
Copy link
Member
@orium orium commented Jul 25, 2023

No description provided.

kflansburg
kflansburg approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor
@kflansburg kflansburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems safe enough since it is not modifying any existing methods. Is this something we want to expose via the C API?

@orium
Copy link
Member Author
orium commented Jul 27, 2023

This seems safe enough since it is not modifying any existing methods. Is this something we want to expose via the C API?

Sounds reasonable. Added.

@orium
Copy link
Member Author
orium commented Jul 27, 2023

I've added a release commit to streamline things.

@inikulin inikulin merged commit 56f17ce into cloudflare:master Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inikulin inikulin inikulin approved these changes

@scotchmist scotchmist scotchmist approved these changes

@kflansburg kflansburg kflansburg approved these changes

@jongiddy jongiddy Awaiting requested review from jongiddy

@Noah-Kennedy Noah-Kennedy Awaiting requested review from Noah-Kennedy Noah-Kennedy is a code owner

@jasnell jasnell Awaiting requested review from jasnell jasnell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@orium @inikulin @scotchmist @kflansburg
0