8000 fix: reject invalid identity zone by klaus-sap · Pull Request #2711 · cloudfoundry/uaa · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: reject invalid identity zone #2711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 19, 2024
Merged

fix: reject invalid identity zone #2711

merged 6 commits into from
Feb 19, 2024

Conversation

klaus-sap
Copy link
Contributor

JdbcScimUserProvisioning.create() and update() so far accepted invalid identity zone ids
Needed to adapt two test classes to fix this

@klaus-sap klaus-sap requested a review from strehle February 5, 2024 13:31
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/186982610

The labels on this github issue will be updated when the story is started.

@klaus-sap klaus-sap requested a review from strehle February 5, 2024 15:52
@strehle strehle requested a review from a team February 5, 2024 17:41
@klaus-sap
Copy link
Contributor Author
klaus-sap commented Feb 6, 2024 •
edited
Loading

#2712 has been merged

@klaus-sap klaus-sap added blocked Issue or PR is blocked waiting-4-pr Pull-Request is wanted in order to proceed and removed blocked Issue or PR is blocked labels Feb 6, 2024
@klaus-sap klaus-sap removed the waiting-4-pr Pull-Request is wanted in order to proceed label Feb 8, 2024
@klaus-sap klaus-sap requested a review from a team February 9, 2024 13:49
Tallicia
Tallicia approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor
@Tallicia Tallicia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I like the more specific exception usage and the additional test as well as including zone with the zoneID.

@Tallicia
Copy link
Contributor

Is this ready to merge? Or is there any prerequisite this depends on before merging?

@klaus-sap klaus-sap merged commit 25f463a into develop Feb 19, 2024
@klaus-sap klaus-sap deleted the create_user_check_idz branch February 19, 2024 08:16
@swalchemist swalchemist mentioned this pull request Feb 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tallicia Tallicia Tallicia approved these changes

@strehle strehle strehle approved these changes

@adrianhoelzl-sap adrianhoelzl-sap adrianhoelzl-sap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Foundational Infrastructure Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@klaus-sap @cf-gitbot @Tallicia @strehle @adrianhoelzl-sap
0