add some info about extension attributes #1335
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duglin
commented
Apr 17, 2025
| OPTIONAL CloudEvent extension context attributes XML elements. From an XSD | ||
| perspective, this is the equivalent of there being an | ||
| `<xs:any minOccurs="0"/>` element defined as a sibling to the other | ||
| CloudEvent context attribute XML elements. |
There was a problem hiding this comment.
This is the only real change in the PR. The rest of it was just pretty-printing things to wrap at 80 columns
There was a problem hiding this comment.
I think "optional" is confusing here - it suggests that any "required" CloudEvent extension context attributes aren't included here. In the context of extensions, "required" only means "required if you're using the extension" (see our deprecation extension for an example).
I think we should just remove OPTIONAL here.
Fixes cloudevents#1014 Signed-off-by: Doug Davis <duglin@gmail.com>
|
on hold - waiting for @JemDay to propose some alternative text |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1014