save-mark-and-excursion that nasty call to check-parens #3818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasty (check-parens) it mess up marks selection in my idiosyncratic config of emacs So I put it in (save-mark-and-excursion) instead of only (save-excursion) The only one that was messing with my usage was in "cider-completion-get-info-context-at-point" but who knows, maybe "cider-completion-get-context-at-point" also mess someone's emacs usage So to be safe, did it to both
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nasty (check-parens)
it mess up marks selection in my idiosyncratic config of emacs
i.e when activating a mark, then moving around, and suddenly
cider-completion-get-info-context-at-point' get triggered by a timer, and mess-up my desired mark-region by another mark-region created from a mix of my starting point of activating mark and then end point ofcheck-parens'So I put it in (save-mark-and-excursion) instead of only (save-excursion)
The only one that was messing with my usage was in "cider-completion-get-info-context-at-point"
but who knows, maybe "cider-completion-get-context-at-point" also mess someone's emacs usage
So to be safe, did it to both, also because kinda hard to pinpoint the issue from a user perspective with an emacs loaded full of so many modes & customization, because its triggered by a timer...
Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test)eldev lint) which is based onelisp-lintand includescheckdoc, check-declare, packaging metadata, indentation, and trailing whitespace checks.Thanks!