fix: [ENG-2104] fix kgo consumer to gracefully fail on network failure #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: xwiillzcl <xwiillzcl@users.noreply.github.com>
…er-bug-that-hang-connection
59c93ff to
6e86b36
Compare
…er-bug-that-hang-connection
| @@ -44,6 +44,7 @@ require ( | |||
| go.opentelemetry.io/otel/sdk v1.30.0 | |||
| go.opentelemetry.io/otel/trace v1.30.0 | |||
| go.opentelemetry.io/proto/otlp v1.0.0 | |||
| go.uber.org/goleak v1.2.1 | |||
There was a problem hiding this comment.
This is great, many tests would benefit from this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with the consumer that happens when the network fails and we try to resubscribe, this scenario prevents the closure of the client and we hold a zombie consumer with redpanda.
This is to prevent this issue, this refactor ensure that we always close the client at the end of the execution and that we never reuse the same client. This increase the resiliency of the system.