Fix updating scoop bucket, homebrew-core formula on release #2056
Conversation
Goreleaser can no longer do this for us since we're always creating a draft release initially.
Now that Goreleaser doesn't need to update any external repositories, we can use the default generated GITHUB_TOKEN for releases.
The gh formula in homebrew-core went back and forth between git-style and tarball-style. Now that it's back to tarball, update the action to reflect that.
|
This feels wrong to me. Why wouldn't we be submitting something upstream to goreleaser? Why bother using goreleaser if we're going to selectively write our own tooling for certain types of releases? I appreciate that we want this fixed prior to the next release but I've submitted PRs to goreleaser in the past (for scoop related issues, iirc) and it's been a quick and positive experience. |
@vilmibm We could definitely consider it, but I'm not sure what kind of change should we submit upstream. By skipping the scoop pipeline for draft releases, goreleaser is working as designed. If we do add to it some functionality to publish a scoop bucket even for draft releases, perhaps via a flag, then we are publishing to scoop something that hasn't been published as a release yet. Ideally, goreleaser could let us repeatedly run |
|
@vilmibm Merging for now to aid with today's release; let's continue the upstream contribution discussion elsewhere! 👍 |
|
An alternative for this would be setting up your Scoop bucket (since you still insist you need it...) in the same way the official buckets work, eg. watch for GitHub releases and update when a new release comes out. That would just use existing Scoop tooling. |
|
@mislav I don't think I'd grasped the gravity of using goreleaser to only do draft releases; if we're going to continue down that route then, yeah, I don't have a good suggestion of something to push upstream since it would require changing goreleaser's flow at a high level. |
Goreleaser can no longer bump our scoop bucket for us since we're always creating a draft release initially.
Fixes #1684
Followup to #1615 (review)
Followup to #1470