8000 hide stuff by vilmibm · Pull Request #897 · cli/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

hide stuff #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 11, 2020
Merged

hide stuff #897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f0a199
de-register review until it's ready to ship
vilmibm May 11, 2020
1675a67
hide credits from main help
vilmibm May 11, 2020
5695958
skip review tests for now
vilmibm May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion command/pr_review.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ import (
)

func init() {
prCmd.AddCommand(prReviewCmd)
// TODO re-register post release
// prCmd.AddCommand(prReviewCmd)

prReviewCmd.Flags().BoolP("approve", "a", false, "Approve pull request")
prReviewCmd.Flags().BoolP("request-changes", "r", false, "Request changes on a pull request")
Expand Down
7 changes: 7 additions & 0 deletions command/pr_review_test.go
View file
Open in desktop
8000
Original file line number Diff line numberDiff line change
Expand Up @@ -8,6 +8,7 @@ import (
)

func TestPRReview_validation(t *testing.T) {
t.Skip("skipping until release is done")
initBlankContext("", "OWNER/REPO", "master")
http := initFakeHTTP()
for _, cmd := range []string{
Expand All @@ -22,6 +23,7 @@ func TestPRReview_validation(t *testing.T) {
}

func TestPRReview_url_arg(t *testing.T) {
t.Skip("skipping until release is done")
initBlankContext("", "OWNER/REPO", "master")
http := initFakeHTTP()
http.StubRepoResponse("OWNER", "REPO")
Expand Down Expand Up @@ -67,6 +69,7 @@ func TestPRReview_url_arg(t *testing.T) {
}

func TestPRReview_number_arg(t *testing.T) {
t.Skip("skipping until release is done")
initBlankContext("", "OWNER/REPO", "master")
http := initFakeHTTP()
http.StubRepoResponse("OWNER", "REPO")
Expand Down Expand Up @@ -112,6 +115,7 @@ func TestPRReview_number_arg(t *testing.T) {
}

func TestPRReview_no_arg(t *testing.T) {
t.Skip("skipping until release is done")
initBlankContext("", "OWNER/REPO", "feature")
http := initFakeHTTP()
http.StubRepoResponse("OWNER", "REPO")
Expand Down Expand Up @@ -147,6 +151,7 @@ func TestPRReview_no_arg(t *testing.T) {
}

func TestPRReview_blank_comment(t *testing.T) {
t.Skip("skipping until release is done")
initBlankContext("", "OWNER/REPO", "master")
http := initFakeHTTP()
http.StubRepoResponse("OWNER", "REPO")
Expand All @@ -156,6 +161,7 @@ func TestPRReview_blank_comment(t *testing.T) {
}

func TestPRReview_blank_request_changes(t *testing.T) {
t.Skip("skipping until release is done")
initBlankContext("", "OWNER/REPO", "master")
http := initFakeHTTP()
http.StubRepoResponse("OWNER", "REPO")
Expand All @@ -165,6 +171,7 @@ func TestPRReview_blank_request_changes(t *testing.T) {
}

func TestPRReview(t *testing.T) {
t.Skip("skipping until release is done")
type c struct {
Cmd string
ExpectedEvent string
Expand Down
2 changes: 1 addition & 1 deletion command/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ func rootHelpFunc(command *cobra.Command, s []string) {
s := " " + rpad(c.Name()+":", c.NamePadding()) + c.Short
if includes(coreCommandNames, c.Name()) {
coreCommands = append(coreCommands, s)
} else {
} else if c != creditsCmd {
additionalCommands = append(additionalCommands, s)
}
}
Expand Down
0