Fix PR create regression around title and body when there is only one commit #8707

williammartin · 2024-02-16T16:56:28Z

Description

Prior to #8423, when running gh pr create on a branch with a single commit, the title and body of the PR would be prefilled as if using --fill-first, using the commit summary for the title and the description for the body:

cli/pkg/cmd/pr/create/create.go

Lines 411 to 423 in dd25f88

    
           commits, err := gitClient.Commits(context.Background(), baseRef, headRef) 
        
           if err != nil { 
        
           	return err 
        
           } 
        
           if len(commits) == 1 || useFirstCommit { 
        
           	commitIndex := len(commits) - 1 
        
           	state.Title = commits[commitIndex].Title 
        
           	body, err := gitClient.CommitBody(context.Background(), commits[commitIndex].Sha) 
        
           	if err != nil { 
        
           		return err 
        
           	} 
        
           	state.Body = body 
        
           } else {

In #8423 a change was made such that this no longer applied for PRs with one commit. This meant that the prefilled title would be a sanitized form of the branch name, as happens when providing --fill or --fill-verbose.

This PR adds a test that validates that the commit information returned from git -c log.ShowSignature=false log --pretty=format:%H,%s,%b --cherry origin/master...feature is used in the pull request mutation when there is exactly one commit.

Reviewer Notes

I've taken the simplest approach to fixing this regression by adding the conditional back. I will follow this with another PR that introduces a new Filler abstraction to tease apart some of this intertwined logic (for example, after #8423 the commit titles will be bolded in the PR body even if there is no description, which is a change from before).

Additionally, it's also worth noting that there is a strange interaction when running gh pr create --fill with just one commit on the git branch in that the code will fall into the 1 commit branch as opposed to the expected else. However, this has always been the behaviour so I don't think we should "fix" it right now.

CC @allyjweir @guerinoni

andyfeller

✨ thanks for sussing this out, @williammartin

guerinoni

Thanks! LGTM

andyfeller · 2024-02-16T17:12:18Z

Just because it is late in the evening for @williammartin, I'm going to merge this and get a patch release out. Once again, thanks @williammartin for figuring this out and @werkshy for your understanding and patience. 🙇

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ajeetdsouza/zoxide](https://togithub.com/ajeetdsouza/zoxide) | patch | `v0.9.3` -> `v0.9.4` | | [aquaproj/aqua-registry](https://togithub.com/aquaproj/aqua-registry) | minor | `v4.135.0` -> `v4.140.0` | | [cli/cli](https://togithub.com/cli/cli) | patch | `v2.44.0` -> `v2.44.1` | | [eza-community/eza](https://togithub.com/eza-community/eza) | patch | `v0.18.3` -> `v0.18.4` | | [gruntwork-io/terragrunt](https://togithub.com/gruntwork-io/terragrunt) | patch | `v0.55.4` -> `v0.55.9` | | [helm/helm](https://togithub.com/helm/helm) | patch | `v3.14.1` -> `v3.14.2` | | [weaveworks/eksctl](https://togithub.com/weaveworks/eksctl) | minor | `v0.171.0` -> `v0.172.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ajeetdsouza/zoxide (ajeetdsouza/zoxide)</summary> ### [`v0.9.4`](https://togithub.com/ajeetdsouza/zoxide/releases/tag/v0.9.4): 0.9.4 [Compare Source](https://togithub.com/ajeetdsouza/zoxide/compare/v0.9.3...v0.9.4) ##### Changed - zsh: improved Space-Tab completions. </details> <details> <summary>aquaproj/aqua-registry (aquaproj/aqua-registry)</summary> ### [`v4.140.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.140.0) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.139.0...v4.140.0) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.140.0) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.140.0) | aquaproj/aqua-registry@v4.139.0...v4.140.0 #### 🎉 New Packages [#20226](https://togithub.com/aquaproj/aqua-registry/issues/20226) [bridgecrewio/checkov](https://togithub.com/bridgecrewio/checkov): Prevent cloud misconfigurations and find vulnerabilities during build-time in infrastructure as code, container images and open source packages with Checkov by Bridgecrew [@florianmutter](https://togithub.com/florianmutter) #### 🎉 New Contributors Thank you for your contribution! [@florianmutter](https://togithub.com/florianmutter) [#20226](https://togithub.com/aquaproj/aqua-registry/issues/20226) ### [`v4.139.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.139.0) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.138.0...v4.139.0) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.139.0) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.139.0) | aquaproj/aqua-registry@v4.138.0...v4.139.0 #### 🎉 New Packages [#20129](https://togithub.com/aquaproj/aqua-registry/issues/20129) [gptscript-ai/gptscript](https://togithub.com/gptscript-ai/gptscript): Natural Language Programming [#20179](https://togithub.com/aquaproj/aqua-registry/issues/20179) [mgechev/revive](https://togithub.com/mgechev/revive): ~6x faster, stricter, configurable, extensible, and beautiful drop-in replacement for golint [@ponkio-o](https://togithub.com/ponkio-o) #### Fixes [#20134](https://togithub.com/aquaproj/aqua-registry/issues/20134) pacedotdev/oto: Follow up changes of oto v0.14.4 ### [`v4.138.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.138.0) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.137.0...v4.138.0) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.138.0) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.138.0) | aquaproj/aqua-registry@v4.137.0...v4.138.0 #### 🎉 New Packages [#20106](https://togithub.com/aquaproj/aqua-registry/issues/20106) [zoncoen/scenarigo](https://togithub.com/zoncoen/scenarigo): An end-to-end scenario testing tool for HTTP/gRPC server [@ponkio-o](https://togithub.com/ponkio-o) ### [`v4.137.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.137.0) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.136.0...v4.137.0) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.137.0) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.137.0) | aquaproj/aqua-registry@v4.136.0...v4.137.0 #### 🎉 New Packages [#20078](https://togithub.com/aquaproj/aqua-registry/issues/20078) [astral-sh/uv](https://togithub.com/astral-sh/uv): An extremely fast Python package installer and resolver, written in Rust #### Fixes [#20079](https://togithub.com/aquaproj/aqua-registry/issues/20079) bufbuild/buf: Support linux/arm64 and regenerate the setting by the command `cmdx s` [@sugoi-wada](https://togithub.com/sugoi-wada) ### [`v4.136.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.136.0) [Compare Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.135.0...v4.136.0) [Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.136.0) | [Pull Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.136.0) | aquaproj/aqua-registry@v4.135.0...v4.136.0 #### 🎉 New Packages [#20047](https://togithub.com/aquaproj/aqua-registry/issues/20047) [martinvonz/jj](https://togithub.com/martinvonz/jj): A Git-compatible VCS that is both simple and powerful [@Omochice](https://togithub.com/Omochice) #### Fixes [#20039](https://togithub.com/aquaproj/aqua-registry/issues/20039) golang/vuln/govulncheck: Change version_source to github_tag This change fixes the bug that `aqua g golang/vuln/govulncheck` can't get versions. </details> <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.44.1`](https://togithub.com/cli/cli/releases/tag/v2.44.1): GitHub CLI 2.44.1 [Compare Source](https://togithub.com/cli/cli/compare/v2.44.0...v2.44.1) #### What's Changed - Fix PR create regression around title and body when there is only one commit by [@williammartin](https://togithub.com/williammartin) in [https://github.com/cli/cli/pull/8707](https://togithub.com/cli/cli/pull/8707) **Full Changelog**: cli/cli@v2.44.0...v2.44.1 </details> <details> <summary>eza-community/eza (eza-community/eza)</summary> ### [`v0.18.4`](https://togithub.com/eza-community/eza/releases/tag/v0.18.4): eza v0.18.4 [Compare Source](https://togithub.com/eza-community/eza/compare/v0.18.3...v0.18.4) ### Changelog #### \[0.18.4] - 2024-02-22 ##### Bug Fixes - Classification width should be taken into account with -F=auto ##### Build - Bump libc from 0.2.152 to 0.2.153 - Bump chrono from 0.4.33 to 0.4.34 - Bump trycmd from 0.14.20 to 0.15.0 ### Checksums #### sha256sum 6d3d312a076493c2acfc4cb6682d4c40a1d20dbd0c8319a0d6bf299de2191367 ./target/bin-0.18.4/eza_aarch64-unknown-linux-gnu.tar.gz 15e6c18fbdba81a67df9707919be5bd7149f09e11f3749c6dac9244d95e0ad41 ./target/bin-0.18.4/eza_aarch64-unknown-linux-gnu.zip 02d24793a2866a0bc62f00deb056df9ebdd1d1b47d6a0f095cf44fad4483f384 ./target/bin-0.18.4/eza_arm-unknown-linux-gnueabihf.tar.gz 7c73b0acb8c2d79b47c46d2141520cff5281f4f677a415862a245f4b8304b5d6 ./target/bin-0.18.4/eza_arm-unknown-linux-gnueabihf.zip 58c70a5d0ad73b5bbfff33f964fa3cf8829eb95ccf55ceccbceaba026577268d ./target/bin-0.18.4/eza.exe_x86_64-pc-windows-gnu.tar.gz 73ae86d864f20034e2b48e04207dc4e8954eb70115f0799a020b8ece7cd24eea ./target/bin-0.18.4/eza.exe_x86_64-pc-windows-gnu.zip 396b6b07784c709ad7874d01b6e0d8de130faa806555ddc18997742c0666acf6 ./target/bin-0.18.4/eza_x86_64-unknown-linux-gnu.tar.gz 53648130bb8a8748cb92bb0b532ca41a136445aa3eb902d2faca2d254ae3f307 ./target/bin-0.18.4/eza_x86_64-unknown-linux-gnu.zip d05f70dae388412cfe9e77997e2f2069525098e7f814838dc4c53667d932798a ./target/bin-0.18.4/eza_x86_64-unknown-linux-musl.tar.gz 87702215535d2a105d2f7d152d91376cc6e475e523a59ea56b7289ded472c034 ./target/bin-0.18.4/eza_x86_64-unknown-linux-musl.zip #### md5sum 030da7df0048265b84eb159fa17383ca ./target/bin-0.18.4/eza_aarch64-unknown-linux-gnu.tar.gz e29149c1e0e6b057dda4e7d8567393fa ./target/bin-0.18.4/eza_aarch64-unknown-linux-gnu.zip f4261bbc7a0835a8b4b5f2d5abd9fa94 ./target/bin-0.18.4/eza_arm-unknown-linux-gnueabihf.tar.gz de8f492baf7a7f5fe0104c61df07fc3f ./target/bin-0.18.4/eza_arm-unknown-linux-gnueabihf.zip 8aa8f2f25b044b3789fd555410e2181c ./target/bin-0.18.4/eza.exe_x86_64-pc-windows-gnu.tar.gz 41d2fe7cc128ee7d64cb4b080bab474f ./target/bin-0.18.4/eza.exe_x86_64-pc-windows-gnu.zip 2c9774ad6d2cd1b84afd52477a429957 ./target/bin-0.18.4/eza_x86_64-unknown-linux-gnu.tar.gz 16fbcd8971013c2703bd1fb1ff8191f5 ./target/bin-0.18.4/eza_x86_64-unknown-linux-gnu.zip be486fc8383e4c5175de9e710a9dc081 ./target/bin-0.18.4/eza_x86_64-unknown-linux-musl.tar.gz 71b719d314d2e84d8b163a9d2932edd2 ./target/bin-0.18.4/eza_x86_64-unknown-linux-musl.zip #### blake3sum 4a191b43c7cfd735d53652acaee617932764c94d6eb65b91bce8f5b971ae2f44 ./target/bin-0.18.4/eza_aarch64-unknown-linux-gnu.tar.gz ebd40d6ca7ab2a27d2b05b9cc139767d1c8a9a5e8f1ab25c72ca520db3b7f174 ./target/bin-0.18.4/eza_aarch64-unknown-linux-gnu.zip 81db0baca4ca163a584434b021e6027a333fe7dc7a6aef36b89a1a5f6e91a77a ./target/bin-0.18.4/eza_arm-unknown-linux-gnueabihf.tar.gz 02e2da4386e2f29342bb8e5a6d89f8afda0ca97ae70a5daaeb049605729004c0 ./target/bin-0.18.4/eza_arm-unknown-linux-gnueabihf.zip 17a6f4a5beba8db87b3ccc12ab36935c2155ee9f2ca8a794ae2ab8bc2780888f ./target/bin-0.18.4/eza.exe_x86_64-pc-windows-gnu.tar.gz 76e3181f3ff2de0afd766cd094cc1c678b06cd9832b7e45975061118e84b14c1 ./target/bin-0.18.4/eza.exe_x86_64-pc-windows-gnu.zip 640ee1877dc80ffb56b1396fb862b2db61aa3b81265486303e453fad25ef04d7 ./target/bin-0.18.4/eza_x86_64-unknown-linux-gnu.tar.gz 4696fdddb4fd4523428fbb4d7214320e690be0cb897f0fe348c4b13bce697061 ./target/bin-0.18.4/eza_x86_64-unknown-linux-gnu.zip acc645214c98d82439c020d243543909c0da549706e7a6987323b718cf62dd15 ./target/bin-0.18.4/eza_x86_64-unknown-linux-musl.tar.gz 20584a9776aab9bd97d14c0b0e52cc850d84abf0dfbc5cc6649b220ac527a895 ./target/bin-0.18.4/eza_x86_64-unknown-linux-musl.zip </details> <details> <summary>gruntwork-io/terragrunt (gruntwork-io/terragrunt)</summary> ### [`v0.55.9`](https://togithub.com/gruntwork-io/terragrunt/releases/tag/v0.55.9) [Compare Source](https://togithub.com/gruntwork-io/terragrunt/compare/v0.55.8...v0.55.9) #### Updated CLI args, config attributes and blocks - `dependency` #### Description - Fixed data race in dependency computation #### Special thanks Special thanks to [@vladlosev](https://togithub.com/vladlosev) for their contribution! #### Related links - [https://github.com/gruntwork-io/terragrunt/pull/2942](https://togithub.com/gruntwork-io/terragrunt/pull/2942) ### [`v0.55.8`](https://togithub.com/gruntwork-io/terragrunt/releases/tag/v0.55.8) [Compare Source](https://togithub.com/gruntwork-io/terragrunt/compare/v0.55.7...v0.55.8) #### What's Changed - Fixing typo in the log message when using catalog by [@yhakbar](https://togithub.com/yhakbar) in [https://github.com/gruntwork-io/terragrunt/pull/2960](https://togithub.com/gruntwork-io/terragrunt/pull/2960) #### New Contributors - [@yhakbar](https://togithub.com/yhakbar) made their first contribution in [https://github.com/gruntwork-io/terragrunt/pull/2960](https://togithub.com/gruntwork-io/terragrunt/pull/2960) **Full Changelog**: gruntwork-io/terragrunt@v0.55.7...v0.55.8 ### [`v0.55.7`](https://togithub.com/gruntwork-io/terragrunt/releases/tag/v0.55.7) [Compare Source](https://togithub.com/gruntwork-io/terragrunt/compare/v0.55.6...v0.55.7) #### Description - Update go version to 1.21.7 to fix CVEs #### Related links - [https://github.com/gruntwork-io/terragrunt/pull/2951](https://togithub.com/gruntwork-io/terragrunt/pull/2951) ### [`v0.55.6`](https://togithub.com/gruntwork-io/terragrunt/releases/tag/v0.55.6) [Compare Source](https://togithub.com/gruntwork-io/terragrunt/compare/v0.55.5...v0.55.6) #### Updated CLI args, config attributes and blocks - `dependency` #### Description - Fix nested dependency parsing #### Related links - [https://github.com/gruntwork-io/terragrunt/pull/2957](https://togithub.com/gruntwork-io/terragrunt/pull/2957) ### [`v0.55.5`](https://togithub.com/gruntwork-io/terragrunt/releases/tag/v0.55.5) [Compare Source](https://togithub.com/gruntwork-io/terragrunt/compare/v0.55.4...v0.55.5) #### Description - Added support for OpenTelemetry metrics and traces #### Related links - [https://github.com/gruntwork-io/terragrunt/pull/2921](https://togithub.com/gruntwork-io/terragrunt/pull/2921) </details> <details> <summary>helm/helm (helm/helm)</summary> ### [`v3.14.2`](https://togithub.com/helm/helm/releases/tag/v3.14.2): Helm v3.14.2 [Compare Source](https://togithub.com/helm/helm/compare/v3.14.1...v3.14.2) Helm v3.14.2 is a security (patch) release. Users are strongly recommended to update to this release. A Helm contributor discovered uninitialized variable vulnerability when Helm parses index and plugin yaml files missing expected content. Jakub Ciolek with AlphaSense discovered the vulnerability. #### Installation and Upgrading Download Helm v3.14.2. The common platform binaries are here: - [MacOS amd64](https://get.helm.sh/helm-v3.14.2-darwin-amd64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.14.2-darwin-amd64.tar.gz.sha256sum) / 64c633ae194bde77b7e7b7936a2814a7417817dc8b7bb7d270bd24a7a17b8d12) - [MacOS arm64](https://get.helm.sh/helm-v3.14.2-darwin-arm64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.14.2-darwin-arm64.tar.gz.sha256sum) / ff502fd39b06497fa3d5a51ec2ced02b9fcfdb0e9a948d315fb1b2f13ddc39fb) - [Linux amd64](https://get.helm.sh/helm-v3.14.2-linux-amd64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.14.2-linux-amd64.tar.gz.sha256sum) / 0885a501d586c1e949e9b113bf3fb3290b0bbf74db9444a1d8c2723a143006a5) - [Linux arm](https://get.helm.sh/helm-v3.14.2-linux-arm.tar.gz) ([checksum](https://get.helm.sh/helm-v3.14.2-linux-arm.tar.gz.sha256sum) / b70fb6fa2cdf0a5c782320c9d7e7b155fcaec260169218c98316bb3cf0d431d9) - [Linux arm64](https://get.helm.sh/helm-v3.14.2-linux-arm64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.14.2-linux-arm64.tar.gz.sha256sum) / c65d6a9557bb359abc2c0d26670de850b52327dc3976ad6f9e14c298ea3e1b61) - [Linux i386](https://get.helm.sh/helm-v3.14.2-linux-386.tar.gz) ([checksum](https://get.helm.sh/helm-v3.14.2-linux-386.tar.gz.sha256sum) / 0e08cd56cc952ab4646c57c5ec7cde2412c39373aec3df659a14597dd9874461) - [Linux ppc64le](https://get.helm.sh/helm-v3.14.2-linux-ppc64le.tar.gz) ([checksum](https://get.helm.sh/helm-v3.14.2-linux-ppc64le.tar.gz.sha256sum) / f3bc8582ff151e619cd285d9cdf9fef1c5733ee5522d8bed2ef680ef07f87223) - [Linux s390x](https://get.helm.sh/helm-v3.14.2-linux-s390x.tar.gz) ([checksum](https://get.helm.sh/helm-v3.14.2-linux-s390x.tar.gz.sha256sum) / 7bda34aa26638e5116b31385f3b781172572175bf4c1ae00c87d8b154458ed94) - [Linux riscv64](https://get.helm.sh/helm-v3.14.2-linux-riscv64.tar.gz) ([checksum](https://get.helm.sh/helm-v3.14.2-linux-riscv64.tar.gz.sha256sum) / f6278facd3e2e6af52a5f6d038f2149428d115ba2b4523edbe5889d1170e9203) - [Windows amd64](https://get.helm.sh/helm-v3.14.2-windows-amd64.zip) ([checksum](https://get.helm.sh/helm-v3.14.2-windows-amd64.zip.sha256sum) / aa094e435da74ad574f96924c37ecd0c75f0be707ac604ef97ed6021d6bc0784) This release was signed with ` 672C 657B E06B 4B30 969C 4A57 4614 49C2 5E36 B98E ` and can be found at [@mattfarina](https://togithub.com/mattfarina) [keybase account](https://keybase.io/mattfarina). Please use the attached signatures for verifying this release using `gpg`. The [Quickstart Guide](https://helm.sh/docs/intro/quickstart/) will get you going from there. For **upgrade instructions** or detailed installation notes, check the [install guide](https://helm.sh/docs/intro/install/). You can also use a [script to install](https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3) on any system with `bash`. #### What's Next - 3.14.3 will contain only bug fixes and be released on March 13, 2024. - 3.15.0 is the next feature release and will be on May 08, 2024. </details> <details> <summary>weaveworks/eksctl (weaveworks/eksctl)</summary> ### [`v0.172.0`](https://togithub.com/eksctl-io/eksctl/releases/tag/v0.172.0): eksctl 0.172.0 (permalink) [Compare Source](https://togithub.com/weaveworks/eksctl/compare/0.171.0...0.172.0-rc.0) ### Release v0.172.0 #### 🎯 Improvements - Fix checks for updated addon versions ([#7471](https://togithub.com/weaveworks/eksctl/issues/7471)) - Check for empty region before invoking API in AWS SDK ([#7523](https://togithub.com/weaveworks/eksctl/issues/7523)) #### 🐛 Bug Fixes - Revert removing RetryMetricsHeader in presigned requests ([#7563](https://togithub.com/weaveworks/eksctl/issues/7563)) #### 🧰 Maintenance - Bump dependencies ([#7554](https://togithub.com/weaveworks/eksctl/issues/7554)) - Extract common workflow steps to set up build environment ([#7551](https://togithub.com/weaveworks/eksctl/issues/7551)) #### Acknowledgments The eksctl maintainers would like to sincerely thank: [@a2ush](https://togithub.com/a2ush) and [@mttrb](https://togithub.com/mttrb) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm on thursday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/scottames/dots).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

williammartin added 3 commits February 16, 2024 16:19

Test PR create uses commit title and body when only one commit

237f6e3

Update test to run against trunk

14617e5

Ensure PRs with one commit have title and body prefilled

658e7ac

williammartin requested a review from a team as a code owner February 16, 2024 16:56

williammartin requested review from andyfeller and removed request for a team February 16, 2024 16:56

cliAutomation assigned williammartin Feb 16, 2024

andyfeller approved these changes Feb 16, 2024

View reviewed changes

guerinoni reviewed Feb 16, 2024

View reviewed changes

andyfeller merged commit b07f955 into trunk Feb 16, 2024

andyfeller deleted the wm/fix-pr-create-regression-8706 branch February 16, 2024 17:12

williammartin mentioned this pull request Feb 23, 2024

Add gh pr create --fill-last #8562

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix PR create regression around title and body when there is only one commit #8707

Fix PR create regression around title and body when there is only one commit #8707

	commits, err := gitClient.Commits(context.Background(), baseRef, headRef)
	if err != nil {
	return err
	}
	if len(commits) == 1 \|\| useFirstCommit {
	commitIndex := len(commits) - 1
	state.Title = commits[commitIndex].Title
	body, err := gitClient.CommitBody(context.Background(), commits[commitIndex].Sha)
	if err != nil {
	return err
	}
	state.Body = body
	} else {

Fix PR create regression around title and body when there is only one commit #8707

Fix PR create regression around title and body when there is only one commit #8707

Conversation

Description

Reviewer Notes

Choose a reason for hiding this comment

Choose a reason for hiding this comment