Manually get current user name rather than use api client #7114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilmibm
approved these changes
Mar 9, 2023
samcoe
commented
Mar 9, 2023
| @@ -231,3 +232,34 @@ func sshKeyUpload(httpClient *http.Client, hostname, keyFile string, title strin | |||
|
|
|||
| return add.SSHKeyUpload(httpClient, hostname, f, title) | |||
| } | |||
|
|
|||
| func getCurrentLogin(httpClient httpClient, hostname, authToken string) (string, error) { | |||
There was a problem hiding this comment.
This is more or less equivalent to what happens in api.CurrentLoginName which is why no test changes were necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7112
Due to a regression in our auth flow we were trying to retrieve the current user name before setting the authentication token, so the request was failing as unauthenticated. This changes how we retrieve the current user name to specify the auth token. The most direct way to do this was to manually create a http request rather than using the api client as before. The api client does not have any clean way to inject an auth token or header unfortunately. Note that this regression only applied to users who paste in their auth token during login.