8000 Preserve explicit title & body in `issue create --web` by mislav · Pull Request #538 · cli/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Preserve explicit title & body in issue create --web #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2020

Conversation

mislav
Copy link
Contributor
@mislav mislav commented Feb 24, 2020

Followup to #523, fixes #522

It's sufficient to return a value of type `ghrepo.Interface` instead of
a pointer to an interface. This avoids having to use `*` whenever we are
passing the result of `determineBaseRepo()` into another function that
accepts a `ghrepo.Interface`.
@mislav mislav requested a review from vilmibm February 24, 2020 12:43
On Windows, `&` characters in URLs need to be escaped with `^`, but that
messes up the test expectation for other platforms, so this normalizes it.
@vilmibm vilmibm merged commit 1bfb875 into master Feb 24, 2020
@mislav mislav deleted the issue-create-web-title-body branch February 24, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using web flag on pr/issue create overrides title and body flags
2 participants
0