8000 Enable full tests on all supported curves by dtebbs · Pull Request #327 · clearmatics/zeth · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enable full tests on all supported curves #327

New issue
Jump to bottom
Merged
merged 3 commits into from
Dec 17, 2020
Merged

Enable full tests on all supported curves #327

merged 3 commits into from
Dec 17, 2020

Conversation

dtebbs
Copy link
Contributor
@dtebbs dtebbs commented Dec 9, 2020

Enable running the full tests (currently run for pull requests only) on BLS12-377.

@dtebbs dtebbs changed the title [WIP] Ci curve tests (depends on #325) [WIP] Enable full tests on all supported curves (depends on #325) Dec 9, 2020
@dtebbs dtebbs changed the title [WIP] Enable full tests on all supported curves (depends on #325) Enable full tests on all supported curves (depends on #325) Dec 10, 2020
AntoineRondelet
AntoineRondelet reviewed Dec 16, 2020
View reviewed changes
@dtebbs dtebbs changed the title Enable full tests on all supported curves (depends on #325) Enable full tests on all supported curves Dec 17, 2020
AntoineRondelet
AntoineRondelet approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor
@AntoineRondelet AntoineRondelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@AntoineRondelet
Copy link
Contributor

[Waiting before merging]
If the libsodium issue is now fixed (see comments in #332) #325 will need to remove the changes related to that. This PR will be merged after.

@dtebbs
Copy link
Contributor Author
dtebbs commented Dec 17, 2020

[Waiting before merging]
If the libsodium issue is now fixed (see comments in #332) #325 will need to remove the changes related to that. This PR will be merged after.

As mentioned in #332 (comment) I think this is worth including anyway. This isn't the first time I've seen this particular problem, and relying on fewer servers in order to build can only be good.

@AntoineRondelet AntoineRondelet merged commit ac87a6b into update-libsnark Dec 17, 2020
@AntoineRondelet AntoineRondelet deleted the ci-curve-tests branch December 21, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineRondelet AntoineRondelet AntoineRondelet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@dtebbs @AntoineRondelet
0