8000 Added some basic code style directives for solidity for consistency by AntoineRondelet · Pull Request #318 · clearmatics/zeth · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added some basic code style directives for solidity for consistency #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2020
Merged

Added some basic code style directives for solidity for consistency #318

merged 1 commit into from
Nov 25, 2020

Conversation

AntoineRondelet
Copy link
Contributor

After skimming through the solidity code, I realized that we had a lot of style inconsistencies throughout our files.
Here's an attempt to capture the general trend (but as above, several files don't fully comply with these style directives).

dtebbs
dtebbs reviewed Nov 24, 2020
View reviewed changes
Copy link
Contributor
@dtebbs dtebbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional comment, but LGTM.

@dtebbs dtebbs self-requested a review November 24, 2020 18:01
dtebbs
dtebbs approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor
@dtebbs dtebbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Resubmitting - I meant to click "approve" in the first review)

@AntoineRondelet AntoineRondelet mentioned this pull request Nov 25, 2020
Closed
@AntoineRondelet AntoineRondelet changed the base branch from extend-contribution-guide to develop November 25, 2020 22:41
@AntoineRondelet AntoineRondelet merged commit 13beb67 into develop Nov 25, 2020
@AntoineRondelet AntoineRondelet deleted the extend-code-style-solidity branch November 25, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtebbs dtebbs dtebbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntoineRondelet @dtebbs
0