8000 Add CI for docker builds by eastata · Pull Request #313 · clearmatics/zeth · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add CI for docker builds #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 23, 2020
Merged

Add CI for docker builds #313

merged 5 commits into from
Nov 23, 2020

Conversation

eastata
Copy link
Contributor
@eastata eastata commented Nov 19, 2020 •
edited
Loading

Issue #278

Added

CI will:

  • Build and push to registry docker images zeth-mpc, zeth-client, zeth-prover with docker tag based on git commit Short SHA-1
    • For every commit to develop branch
    • For every PR to master branch
  • Build and push to registry docker images zeth-mpc, zeth-client, zeth-prover with docker tag == git tag and update latest images
  • Build and push to registry docker image zeth-base with docker tag version from git tag and update latest

Updated

  • Current clearmatics/zeth-base:latest image saved as a v0.0.0 in DockerHub DIGEST:sha256:0a3c603a607e970e093b7a384f92e5958bba2dbb0af0eb1eaf786f8fc41d3381
  • Source image for zeth-mpc, zeth-dev, zeth-prover moved from clearmatics/zeth-base:latest to fixed version clearmatics/zeth-base:v0.0.0

Removed

  • DockerHub Autobuild for clearmatics/zeth-base disabled

@eastata eastata self-assigned this Nov 19, 2020
@eastata eastata changed the title Add CI for docker builds [WPI] Add CI for docker builds Nov 19, 2020
@eastata eastata changed the title [WPI] Add CI for docker builds Add CI for docker builds Nov 19, 2020
@eastata eastata mentioned this pull request Nov 19, 2020
Closed
AntoineRondelet
AntoineRondelet reviewed Nov 23, 2020
View reviewed changes
@AntoineRondelet
Copy link
Contributor

Great work, and thanks for the PR @eastata! That's very helpful!

@AntoineRondelet
Copy link
Contributor
AntoineRondelet commented Nov 23, 2020 •
edited
Loading

@eastata can you rebase your branch on top of develop? :) (that'll bring the recent changes that fix the CI for macOS and repair the CI on this PR - see here: #316 where all the CI checks passed).

Also, I saw that you added a tag: https://github.com/clearmatics/zeth/releases/tag/docker-base-v0.0.1
Rebasing will ask for a new tag. Is this tag actually needed? or was it just for testing purposes? (seems like no changes are made to the Dockerfile-base file which would justify a version bump).

@eastata
Copy link
Contributor Author
eastata commented Nov 23, 2020

git tag docker-base-v0.0.1 was to test build docker image clearmatics/zeth-base:v0.0.1

@AntoineRondelet
Copy link
Contributor

git tag docker-base-v0.0.1 was to test build docker image clearmatics/zeth-base:v0.0.1

Alright, let's keep it as a "template" to follow for the next versions of zeth-base.
Note: I saw that you merged develop here, let's keep it that way for simplicity (and to merge this PR asap), but FYI the convention here is to rebase to avoid adding "bi-directional merge commits" in the git history (merging is kept unidirectional as much as we can i.e. master <- develop <- feature or master <- hotfix) :)

@eastata eastata merged commit ac78f07 into develop Nov 23, 2020
@eastata eastata deleted the docker-build branch November 23, 2020 16:38
This was referenced Nov 23, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineRondelet AntoineRondelet AntoineRondelet left review comments

Assignees

@eastata eastata

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eastata @AntoineRondelet
0