8000 Mixer client tidying by dtebbs · Pull Request #302 · clearmatics/zeth · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Mixer client tidying #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Nov 25, 2020
Merged

Mixer client tidying #302

merged 22 commits into from
Nov 25, 2020

Conversation

dtebbs
Copy link
Contributor
@dtebbs dtebbs commented Oct 19, 2020 •
edited
Loading

In preparation for client-side support for other pairings.

@dtebbs dtebbs changed the title WIP: mixer client tidying WIP: mixer client tidying (depends on #300) Oct 20, 2020
@dtebbs dtebbs force-pushed the client-mixer-tidy branch from 8ae4bcc to deac468 Compare October 27, 2020 14:14
@dtebbs dtebbs force-pushed the client-mixer-tidy branch 2 times, most recently from f9c75c7 to 81cb5e9 Compare October 27, 2020 17:45
@dtebbs dtebbs force-pushed the client-mixer-tidy branch 3 times, most recently from e8dc13f to 5fe9174 Compare November 2, 2020 18:46
@dtebbs dtebbs force-pushed the client-mixer-tidy branch from 5fe9174 to 137b60f Compare November 3, 2020 12:54
@dtebbs dtebbs mentioned this pull request Nov 3, 2020
Merged
@dtebbs dtebbs force-pushed the client-mixer-tidy branch 3 times, most recently from 5b36120 to 7f23176 Compare November 9, 2020 09:54
@dtebbs dtebbs changed the base branch from mimc11 to mimc-configurations November 9, 2020 09:56
@dtebbs dtebbs changed the title WIP: mixer client tidying (depends on #300) WIP: mixer client tidying (depends on #309) Nov 9, 2020
@dtebbs dtebbs force-pushed the client-mixer-tidy branch from 7f23176 to b5b147a Compare November 9, 2020 10:31
@dtebbs dtebbs changed the title WIP: mixer client tidying (depends on #309) Mixer client tidying (depends on #309) Nov 9, 2020
@dtebbs dtebbs force-pushed the mimc-configurations branch from eca28ef to 54211f6 Compare November 17, 2020 15:39
@dtebbs dtebbs force-pushed the client-mixer-tidy branch 2 times, most recently from 964ef80 to a74357b Compare November 18, 2020 11:50
@dtebbs dtebbs force-pushed the mimc-configurations branch 2 times, most recently from 87f8df3 to 886387e Compare November 18, 2020 13:30
@AntoineRondelet AntoineRondelet changed the base branch from mimc-configurations to develop November 23, 2020 16:41
AntoineRondelet
AntoineRondelet reviewed Nov 24, 2020
View reviewed changes
libzeth/serialization/proto_utils.cpp

template<> std::string pp_name<libff::alt_bn128_pp>()
{
return std::string("alt-bn128");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think constants are supported by protobuf... Since I can see that these "pairing params names" are hardcoded in several places (here, in client/tests/test_pairing.py, in client/zeth/core/zksnark.py, in client/zeth/core/mimc.py) it would have been great to use some constants defined in the proto config directly.. I think Cap'n Proto can do that (https://capnproto.org/language.html#constants) which may be another argument towards considering switching to that later down the line (see also: #169)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Yes, constants would be helpful in these cases.

@dtebbs dtebbs changed the title Mixer client tidying (depends on #309) Mixer client tidying Nov 24, 2020
dtebbs added 22 commits November 24, 2020 18:30
@dtebbs
client: separate generic contract infrastructure from mixer-specific …
4b2024b 
…functionality
@dtebbs
client: better factoring of mixer functionality
393dd96
@dtebbs
client: remove hard-coded scalar modulus and bit capacity
1194285
@dtebbs
client: further separation of MixerClient and ProverClient
4cf945a
@dtebbs
libzeth: use constexpr in some functions to use result at compile time
06b4a97
@dtebbs
better factoring of residual bit generation and decoding. more consis…
9c6b143 
…tent ordering.
@dtebbs
simplify digest encoding to field elements
00a830d
@dtebbs
code public values in first bits of field (independent of pairing)
542e42d
@dtebbs
contracts: further factoring out of curve-specific code
7af1a45
@dtebbs
contracts: fixes and small refactor in Pghr13 for consistency
87c8e58
@dtebbs
contracts: move opaque verification key onto BaseMixer
33ac654
@dtebbs
contracts: move mix call into BaseMixer
c0fdec4
@dtebbs
contracts: refactor Pghr13 mixer to reuse base class functionality
3e9f9b8
@dtebbs
contracts: move token-related interfaces into their own file
84ab74a
@dtebbs
add pairing name to PairingParameters structre
928cc46
@dtebbs
client: choose mixer contract based on pairing and zksnark name
8fbdf65
@dtebbs
contracts: clean MixerBase
9b11c4a
@dtebbs
contracts: Merkle tree abstraction (base class with abstract hash fun…
020ecea 
…ction)
@dtebbs
contracts: move choice of Merkle tree hash function to pairing-specif…
07afa0e 
…ic base class
@dtebbs
8000 libzeth: tree hash parameterized by pairing
a79b9e8
@dtebbs
client: dynamically choose Merkle tree hash depending on pairing
f029ec5
@dtebbs
client: rename protoutils to proto_utils
f6c17d5
AntoineRondelet
AntoineRondelet approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor
@AntoineRondelet AntoineRondelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @dtebbs

@AntoineRondelet AntoineRondelet merged commit d3314d3 into develop Nov 25, 2020
AntoineRondelet added a commit that referenced this pull request Dec 3, 2020
@AntoineRondelet
Merge pull request #298 from clearmatics/zeth-bls12-377
1de8b41 
Full support for BLS12-377 (depends on #302)
@AntoineRondelet AntoineRondelet deleted the client-mixer-tidy branch December 10, 2020 18:53
@AntoineRondelet AntoineRondelet mentioned this pull request Dec 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineRondelet AntoineRondelet AntoineRondelet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtebbs @AntoineRondelet
0