Zeth client show parameters #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -515,16 +515,17 @@ def mix( | |||
| self, | |||
| mix_params: contracts.MixParameters, | |||
| sender_eth_address: str, | |||
| pub_value: Optional[EtherValue] = None, | |||
| sender_eth_private_key: Optional[bytes], | |||
There was a problem hiding this comment.
That's a general note, not related to this PR in particular.
As a general rule of thumb, passing secret keys/data around is not desirable (at all). That's something to be careful with - we want the "message to come to the sk" (not the other way around) (I comment here because I can see that we pass the private key to functions here)
There was a problem hiding this comment.
Sure. We can iterate in a future pass.
f614cb7 to
aa3c7b5
Compare
|
LGTM |
Make mpc server tests more verbose (depends on #263)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mix --show-parametersflag and related refactor.fix for small output inconsistency when using
mix --wait