8000 Docker cleanup by AntoineRondelet · Pull Request #245 · clearmatics/zeth · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Docker cleanup #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Sep 10, 2020
Merged

Docker cleanup #245

merged 18 commits into from
Sep 10, 2020

Conversation

AntoineRondelet
Copy link
Contributor
@AntoineRondelet AntoineRondelet commented Aug 24, 2020 •
edited
Loading

Package all parts of the code base into their own docker images. This PR introduces:

  • Dockerfile-dev (formerly Dockerfile-zeth): That copies all the zeth repo into an pre-configured alpine container, and which can be used for development matters and for the CI
  • Dockerfile-prover: Build the prover_server and moves the binary into a slim alpine container. The associated image is only useful for people willing to run the prover_server only
  • Dockerfile-client: Moves the client code into an alpine container. The resulting image can be used by people willing to run the client code only. This docker file also builds a static wheels for the cryptography package as per Issues with openssl in Python tests on Alpine #234
  • Dockerfile-mpc: Provides a slim docker image for MPC contributors

@AntoineRondelet
Copy link
Contributor Author
AntoineRondelet commented Aug 24, 2020 •
edited
Loading

Tackles:

Also fixes #12 - since the zeth-prover image now fixes this issue (the prover can be started by running this image on command prover_server and nothing else needs to be done). zeth-dev aims to be a dev environment, so no need to auto start the prover in the background

@AntoineRondelet AntoineRondelet mentioned this pull request Sep 1, 2020
Closed
@AntoineRondelet AntoineRondelet changed the base branch from develop to fix-mpc September 7, 2020 12:12
@AntoineRondelet AntoineRondelet changed the title [WIP] Docker cleanup Docker cleanup Sep 8, 2020
@AntoineRondelet AntoineRondelet force-pushed the docker-cleanup branch 2 times, most recently from 0e681b3 to 7860270 Compare September 8, 2020 17:31
dtebbs
dtebbs suggested changes Sep 9, 2020
View reviewed changes
Copy link
Contributor
@dtebbs dtebbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One small naming thing.

@AntoineRondelet
Started to clean images up
6c305c2
@AntoineRondelet
Used multistage build for the prover_server image
59befcf
@AntoineRondelet
First working docker multistage build
2b9d7df
@AntoineRondelet
Cleaned docker config files
8997d07
@AntoineRondelet
Changed dockerfile used in CI
a1be627
@AntoineRondelet
Added minimal and broken docker image for the zeth client
78c27a0
@AntoineRondelet
Added steps to build missing wheel on alpine
1d5f4b8
@AntoineRondelet
Implemented initial docker multistage build for MPC contributor
4fe1b9c
@AntoineRondelet
Added link to PoT repo
8b4c738
@AntoineRondelet
Removed useless block in libzeth target
c9eef6c
@AntoineRondelet
Merged static build blocks
e6af646
@AntoineRondelet
Cleaned up docker images and upgraded grpc version
82cef60
@AntoineRondelet
Remove useless steps from mpc docker image and added entrypoint
1a89d9c
@AntoineRondelet
Built protobuf manually and addedboth static and shared libs for gRPC…
b6224c3 
… in base image
@AntoineRondelet
Fixed static wheel version mismatch, renamed multistage base images a…
92bfe9f 
…nd fixed forgotten renamings
@AntoineRondelet
Added missing docker commands to READMEs and fixed title hierarchy
680fa8e
@AntoineRondelet
Changed env var to BUILD_ROOT
bdf9b88
@AntoineRondelet AntoineRondelet force-pushed the docker-cleanup branch 2 times, most recently from 8ac0802 to 1388663 Compare September 10, 2020 13:45
@AntoineRondelet AntoineRondelet merged commit 2a11a71 into fix-mpc Sep 10, 2020
AntoineRondelet added a commit that referenced this pull request Sep 10, 2020
@AntoineRondelet
Revert "Merge pull request #245 from clearmatics/docker-cleanup"
0606a7c 
This reverts commit 2a11a71, reversing
changes made to 938fa3c.
@AntoineRondelet AntoineRondelet mentioned this pull request Sep 10, 2020
Merged
@AntoineRondelet AntoineRondelet deleted the docker-cleanup branch September 10, 2020 15:04
@AntoineRondelet AntoineRondelet mentioned this pull request Sep 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtebbs dtebbs dtebbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntoineRondelet @dtebbs
0