8000 Fix build rule scope by AntoineRondelet · Pull Request #235 · clearmatics/zeth · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix build rule scope #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 31, 2020
Merged

Fix build rule scope #235

merged 4 commits into from
Jul 31, 2020

Conversation

AntoineRondelet
Copy link
Contributor
@AntoineRondelet AntoineRondelet commented Jul 30, 2020 •
edited
Loading
  • Added conditional in cmake config to only create make rules if Zeth is the parent project
  • Added missing flags and instructions to the README

@AntoineRondelet AntoineRondelet changed the base branch from master to develop July 30, 2020 15:16
@AntoineRondelet AntoineRondelet changed the title [WIP] Fix build rule scope Fix build rule scope Jul 30, 2020
@AntoineRondelet AntoineRondelet requested a review from dtebbs July 30, 2020 18:01
@AntoineRondelet AntoineRondelet merged commit e576ef2 into develop Jul 31, 2020
@AntoineRondelet AntoineRondelet deleted the fix-build-rule-scope branch August 26, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtebbs dtebbs dtebbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntoineRondelet @dtebbs
0