Changes to support bls12-377 and bw6-761 #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d53ae35 to
e44eb19
Compare
libzeth/tests/circuits/note_test.cpp
Outdated
| using HashT = BLAKE2s_256<FieldT>; | ||
| using HashTreeT = MiMC_mp_gadget<FieldT>; | ||
| using pp = defaults::pp; | ||
| using FieldT = defaults::FieldT; |
There was a problem hiding this comment.
Same question as above, re: FieldT->Field
There was a problem hiding this comment.
Yes, technically we should. I was hesitant because of the number of lines it might touch, but since you raised it I'll include this change.
There was a problem hiding this comment.
I've switched this everywhere. I think we should now be consistent with the type var vs type name convention.
There was a problem hiding this comment.
Yes, technically we should. I was hesitant because of the number of lines it might touch, but since you raised it I'll include this change.
Thanks @dtebbs
Yes, I think it's important to be consistent here
Remove ZKSNARK macro from command line. Use ZETH_SNARK connfig variable across all applications. Move zeth_config types (curves, snarks, etc) into libzeth::defaults namespace.
|
Looking good to me, great to see the library code fully parameterized @dtebbs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ppT, types usepp