10000 Pyclient constant use by dtebbs · Pull Request #204 · clearmatics/zeth · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Pyclient constant use #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 6, 2020
Merged

Pyclient constant use #204

merged 8 commits into from
May 6, 2020

Conversation

dtebbs
Copy link
Contributor
@dtebbs dtebbs commented Apr 23, 2020
  • Consistent naming of constants, and removal of duplicates
  • make some internal constants (implementation details) private
  • replace some hard-coded sizes and offsets with constants

@dtebbs dtebbs force-pushed the pyclient-constant-use branch from 7b8a7b9 to b1ff83f Compare April 23, 2020 12:44
@dtebbs dtebbs changed the title Pyclient constant use [depends on #193] WIP: Pyclient constant use [depends on #193] Apr 23, 2020
@dtebbs dtebbs force-pushed the pyclient-constant-use branch from b1ff83f to 343c491 Compare May 6, 2020 16:36
@dtebbs dtebbs changed the base branch from ik-cca to develop May 6, 2020 16:39
@dtebbs dtebbs changed the title WIP: Pyclient constant use [depends on #193] WIP: Pyclient constant use May 6, 2020
@dtebbs dtebbs changed the title WIP: Pyclient constant use Pyclient constant use May 6, 2020
AntoineRondelet
AntoineRondelet reviewed May 6, 2020
View reviewed changes
@dtebbs dtebbs force-pushed the pyclient-constant-use branch from 343c491 to f7ad1c0 Compare May 6, 2020 18:23
@AntoineRondelet
Copy link
Contributor

Tackles: #203

@dtebbs dtebbs force-pushed the pyclient-constant-use branch from f7ad1c0 to 5c2b24d Compare May 6, 2020 18:36
@dtebbs dtebbs force-pushed the pyclient-constant-use branch from 5c2b24d to 93bfcde Compare May 6, 2020 19:03
@AntoineRondelet AntoineRondelet merged commit 8472ae5 into develop May 6, 2020
@AntoineRondelet AntoineRondelet deleted the pyclient-constant-use branch May 7, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineRondelet AntoineRondelet AntoineRondelet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtebbs @AntoineRondelet
0