Further pyclient types and refactoring #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87f9b41 to
1099076
Compare
| hash_ciphers: str, | ||
| hash_proof: str, | ||
| hash_inputs: str) -> int: | ||
| def _sign( |
There was a problem hiding this comment.
This needs to be moved to signing.py which should contain all the algorithms of the signature scheme we use. Namely, Sign(sk, msg) (returns sigma), Verify(vk, sigma, msg) (return 0/1), KeyGen(\secparam) (returns sk, vk).
Thus, the signature of the function _sign above needs to be modified (cc: @rrtoledo as this is related to the thread:#122 (comment))
1099076 to
51a2b7f
Compare
51a2b7f to
feb86d2
Compare
AntoineRondelet
added a commit
that referenced
this pull request
Dec 13, 2019
Fixing non-malleability vulnerability (depends on #127)
AntoineRondelet
added a commit
that referenced
this pull request
May 6, 2020
Further pyclient types and refactoring
AntoineRondelet
added a commit
that referenced
this pull request
May 6, 2020
Fixing non-malleability vulnerability (depends on #127)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for exposing zeth functionality as CLI tools.
The cli tools are not complete, but this is a good place to merge, to avoid branches diverging too much.