8000 clean up when to call resetBouss instead of every step, adding block … by mjberger · Pull Request #655 · clawpack/geoclaw · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

clean up when to call resetBouss instead of every step, adding block … #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 12, 2025
Merged

clean up when to call resetBouss instead of every step, adding block … #655

merged 5 commits into from
Jun 12, 2025

Conversation

mjberger
Copy link
Contributor
@mjberger mjberger commented Jun 5, 2025

…coo option, adding petsc options to output timing file

@mjberger
clean up when to call resetBouss instead of every step, adding block …
d2f7423 
…coo option, adding petsc options to output timing file
@rjleveque
Copy link
Member

@mjberger: I think you forgot to include buildSparseMatrixSGNcoo_blocks.f90 so I can't test it.

Some minor suggestions:

  1. You introduced is_finalized, maybe it would be clearer down the road to call this bouss_finalized, in keeping with topo_finalized and aux_finalized?

  2. In bouss_module maybe change the comments in these lines:

     !crs = .false.  ! uncomment this line to force COO with SGN for testing
     !origCooFormat = .false.  ! using block format with coo

to

     !crs = .false.  ! set to .false. to force COO with SGN for testing
     !origCooFormat = .false.  ! set to .false. to use block format with coo

to be less confusing, particularly if the user uncomments a line and then changes .false. to .true. in the command without updating the comment.

  1. It might be helpful to have a few more comments somewhere about the differences between these different formats and why they are all available. (For someone else debugging down the road.)

@mjberger mjberger closed this Jun 6, 2025
@mjberger mjberger reopened this Jun 6, 2025
@mjberger
Copy link
Contributor Author
mjberger commented Jun 6, 2025

new comments in bouss_module

@rjleveque
Copy link
Member

Thanks @mjberger!

@rjleveque rjleveque merged commit 162d2c2 into clawpack:master Jun 12, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjberger @rjleveque
0