8000 WIP: Switch to PyTest by mandli · Pull Request #642 · clawpack/geoclaw · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

WIP: Switch to PyTest #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 91 commits into
base: master
Choose a base branch
from
Draft

WIP: Switch to PyTest #642

wants to merge 91 commits into from

Conversation

mandli
Copy link
Member
@mandli mandli commented Apr 22, 2025 •
edited
Loading

A clean attempt at switch the tests over to PyTest. Also moves the tests out of a dedicated directory and aligns each with an example, modifying only what needs to be modified.

Currently Broken Tests

Will update this list as I go to update what is and is not working.

  • Example regression tests:
    • Bowl Slosh the fgmax test is failing, gauge test is passing.
    • dtopo is failing, but if I recall, this started before the switch
    • Multilayer was not compiling - fixed by adding a flag to the Makefile to support linux linking to LAPACK.
    • Storm surge Ike test - is working but there is a bug in how gauges are recorded that is holding up creating new regression data
    • Particles test - regression data differs from output but test data looks fine
    • Chile 2010 Adjoint test - works but forward does not match regression data
  • Python tests:
    • Storm tests

@mandli mandli self-assigned this Apr 22, 2025
@mandli mandli changed the title Switch to PyTest WIP: Switch to PyTest Apr 22, 2025
@mandli mandli marked this pull request as draft April 22, 2025 14:03
mandli added 24 commits April 22, 2025 10:11
@mandli
Merge branch 'master' into update-pytest
6c41c99
@mandli
Try removing PIC version of LAPACK
f4562ba
@mandli
db36a43
@mandli
Fix another silly bug, like with clowns
643ecba
@mandli
Update action script to fix reference error
4a320d9 
Mostly this modernizes/updates the way we checkout the submodules and
the proper branches to canned actions.
@mandli
Minor changes now that things have hopefully been updated/working
9f99614
@mandli
Fix flake errors part I
52b30e9
@mandli
Flake fixes part II
240ac4d
@mandli
Flake fixes part III, the end
a91c9b7
@mandli
Remove global from exported notebook
ec4a4b7
@mandli
Remove __init__ in tests to disable old tests
4d3b878
@mandli
Remove deprecated parameters
84fc58f
@mandli
Move and modify test_data
1473d41 
Also moves test_storm for testing purposes.  Adds a :TODO: comment on
data.py to move from `os.path` to `pathlib`.
@mandli
Add new storm I/O tests but skip a bunch
2c2d487
@mandli
Refactor test_topotools and move test data
027b91a
@mandli
Convert dtopotools tests
9ff69ff
@mandli
Converted etopo1 tests
4d66533
@mandli
Remove setrun changes for bouss
57f6ef6
@mandli
Add units tests
3440822
@mandli
Update test util
6ec0cfc
@mandli
Bowl slosh NetCDF test working
cf8cb39
@mandli
Add better handling of netcdf_test program
d3ad6b0
@mandli
Slightly tweak for better NetCDF flags
25f27d1
@mandli
Minor tweaks
9545ddf
mandli added 19 commits May 9, 2025 10:12
@mandli
Add particles test
b3e2d51 
Also fixes a bug in the storm module left over
@mandli
Remove old particles test
02ac695
@mandli
Add Chile 2010 adjoint test
e2c0461
@mandli
Move maketopo to maketopo_adjoint to avoid name collisions
0a59a39
@mandli
Add forward adjoint test
afa406b 
Had to do some name changing to avoid collisions.  Runs but does not match
existing regression data.
@mandli
Change the way that ATCF data is downloaded
ec94084
@mandli
Fix typo in datetime handling
8a5fccd
@mandli
Remove non-working isaac tests and cleanup storm format test
ea67540
@mandli
Fix setbestsrc function signature bug
a52794e
@mandli
Remove local generation of bathy_geometry.data in test
2631a86
@mandli
Remove old import line
6396cda
@mandli
Remove remaining old test directories
59b6a71
@mandli
Cleanup setrun regarding different isaac formats
8000 c1df91b
@mandli
Remove extra test_storm
a697e4e
@mandli
Reenable storm io tests
58ed514
@mandli
Add vortex example
b077935
@mandli
Add working plotting and test to vortex example
7e5d6ce 
Also adds other additional scripts for convergence, testing of alternative
Riemann solvers, and a PyClaw example.
@mandli
Convert numpy to np
3ae4009
@mandli
Add time check on gauge updates
6c59113
@mandli
Copy link
Member Author
mandli commented May 18, 2025

There are commits that should be merged in other repositories before this may work:

@mandli mandli mentioned this pull request May 21, 2025
Closed
@rjleveque
Copy link
Member
rjleveque commented May 24, 2025 •
edited
Loading

PR #649 suggests merging that one before this, but I think #649 has problems (see the discussion there), so perhaps the regression data needs to be updated in this PR?

@mandli
Copy link
Member Author
mandli commented May 25, 2025

Yeah, we can update the regression data when necessary.

This was referenced Jun 4, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mandli mandli

Labels
examples testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mandli @rjleveque
0