8000 feat: Trigger confirm warning for unsaved changes by Chifez · Pull Request #547 · classroomio/classroomio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Trigger confirm warning for unsaved changes #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: Trigger confirm warning for unsaved changes #547

wants to merge 4 commits into from

Conversation

Chifez
Copy link
Collaborator
@Chifez Chifez commented Mar 4, 2025

What does this PR do?

This PR trigger the confirm warning for unsaved changes, it blocks navigation until an action is confirmed by the user. This changes were added to the

  1. landingpage settings
  2. profile settings
  3. organization settings

Fixes #488

bandicam.2025-03-04.09-02-27-660.mp4

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • Start the dev server and navigate to the settings page
  • make a change and try navigating to another page without saving

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the ClassroomIO Docs if changes were necessary

@github-actions GitHub Actions
Copy link
github-actions bot commented Mar 4, 2025 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link
cloudflare-workers-and-pages bot commented Mar 4, 2025 •
edited
Loading

Deploying courseapp with  Cloudflare Pages  Cloudflare Pages

Latest commit: 340d495
Status: ✅  Deploy successful!
Preview URL: https://e517525e.courseapp-efa.pages.dev
Branch Preview URL: https://trigger-warning.courseapp-efa.pages.dev

View logs

@vercel Vercel
Copy link
vercel bot commented Mar 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cio-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:41am
cio-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 9:41am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Winter Of Code 4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On every settings page, add a warning if saved not hit
1 participant
@Chifez
0