8000 feat: Arrange Course Modal by tunny17 · Pull Request #413 · classroomio/classroomio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Arrange Course Modal #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2024
Merged

feat: Arrange Course Modal #413

merged 2 commits into from
Jul 31, 2024

Conversation

tunny17
Copy link
Collaborator
@tunny17 tunny17 commented Jul 30, 2024

What does this PR do?

This PR Adds the Order feature to the course modal so after the user creates the course, he/she gets to arrange the course in the order they should be followed. Lastly, This PR also adds an empty state for the courses page.

Fixes # ()

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • Create a course

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

@tunny17 tunny17 requested a review from rotimi-best July 30, 2024 08:00
@github-actions GitHub Actions
Copy link

Thank you for following the naming conventions for pull request titles! 🙏

@rotimi-best rotimi-best merged commit a23ce22 into pathway/courseModal Jul 31, 2024
6 of 7 checks passed
rotimi-best added a commit that referenced this pull request Jul 31, 2024
@tunny17 @rotimi-best
feat: Add Course Modal (#407)
3d74200 
* feat: Add Course Modal

* feat: add translation

* fix: feedback fix

* PR Fixes

* feat: Merge Fix

* fix: merge fixes

* feat: Arrange Course Modal (#413)

* fix: merge bug fixes

* feat: Add course modal

* chore: refactor modal and textfield to be much simpler

* remove unused var

* refactor

* remove pathways folder

* rename from PathWay to Pathway

* delete wrong casing files

* rename files

---------

Co-authored-by: Rotimi Best <best@classroomio.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rotimi-best rotimi-best Awaiting requested review from rotimi-best

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tunny17 @rotimi-best
0