fix: validation of username and fullname #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@smritidoneria is attempting to deploy a commit to the Rotimi Best's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions for pull request titles! 🙏 |
rotimi-best
requested changes
Jul 18, 2024
rotimi-best
added a commit
that referenced
this pull request
Jul 26, 2024
* worked on the pathway sidebar and the empty state * worked on the card and modal * worked on the sidebar path * dashboard UI and translations all done * updated the translations * feat: show submissions for live classes * updated the name to pathways and the translations * updated the name to pathways and the translations * fix: lesson widget alignment on page (#396) * fix * fix * fixed overlapping issue * removed console logs * removed extra line * chore: modifies seed data to verify email (#395) * feat: RLS on all tables (#399) * implement RLS * set default course currency to USD * remove unused import * update default currency in course in db * worked on the reviews * updated the prop for the pathway card * fix: auth issue due to org insert rls policy * fix: add style for native select css (#403) * fix: validation on profile page (#398) * fix validation of username and fullname * fix * fix message * Update validator.js * Update Profile.svelte * remove unused functions --------- Co-authored-by: Rotimi Best <best@classroomio.com> * chore: update translations * fix: #404 autosave issue on lesson * docs: start supabase with pnpm * feat: add 4 certificate templates (#295) * add cloud translation api package * feat: Script that auto generates translations for other languages * add comments * fix: broken translation * improve translation * update locck file * clean up * all round trasnlations check * checkpoint * finish up * move to dev dependencies * fix vercel build error * translations fix * - add documentation - translation bug fix * quick adjust * PR Fixes * add new line * update docs * checkpoint * feat: redesign & addition of certificates * text color update * patterned width fix * "student-name" class remove * checkpoint * PR Fix * quick fix * PR Fixes * update certificate ready page for students * PR Fixes * quick cleanup * move fetchCourses into .ts file * feat: give students access to certificates only after completing course * checkpoint * height fix * Merge branch 'main' of https://github.com/rotimi-best/classroomio into classroomio-issue-272 * Fix; merge PR Fix * fix: width of plain & professional certs * PR Fix * feat: add translation * handle error when trying to download a certificate * add fetchExploreCourses * fix: requested reviews * review fixes checkpoint * replace the certificate background * height fix for patterned certififcates * fix more bugs * rename schema --------- Co-authored-by: Rotimi Best <best@classroomio.com> * feat: teacher email should include student details * Update based on reviews * Update based on reviews --------- Co-authored-by: Rotimi Best <best@classroomio.com> Co-authored-by: Smriti Doneria <smritidoneria@gmail.com> Co-authored-by: Vanessa Osuka <77996535+cannarron@users.noreply.github.com> Co-authored-by: Dmytro <31030855+Laurent-di@users.noreply.github.com> Co-authored-by: Adeyemi Adetunji <tvnji01@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The pr allows the validation of username and full name correctly
Fixes #397
Screen.Recording.2024-07-16.at.10.26.42.PM.mov
Type of change
How should this be tested?
go to settings, make the username and full name as empty
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated