autobatching bug fixed. #1666
Open
autobatching bug fixed. #1666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, I don't think my change has anything to do with the continuous integration error Seems to be a problem in the build environment... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Sugg
2C3C
estions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bugfix addresses the problem I already found several years ago. See my comment to Issue #1582.
I don't think it really was the same problem as the original error described in this issue because my problem was in the backward step and now I think #1582 could have been a problem in the forward step.
In any case this change fixes my problem. And the problem was (autobatching = 1):
In this case the backward step in exec.cc called node->backward() with the batch tensor as last argument instead of the correct sub-tensor of this batch.