Add indices checking for parameters in model.cc #1593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there is no indices checking in gradient_l2_norm_dev and sometimes the code could request elements beyond the end of the vector (when k1 = params.size() or k2 = lookup_params.size()). To fix this, we introduce a simple bounds check. params.size() > 8000 ; k1 lookup_params.size() > k2
|
I was about to make a PR to fix this exact same problem. It would have saved me a lot of time had this been merged a year ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no index checking in gradient_l2_norm_dev and sometimes it could access elements beyond the end of the vector (when k1 = params.size() or k2 = lookup_params.size()).
To fix this, we introduce a simple bounds check.
params.size() > k1
lookup_params.size() > k2