Make sure ParameterStorageBase also uses shared pointer for Java interface #1576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rface Its subclasses are marked in dynet_swig.i as using shared pointers: ``` %shared_ptr(dynet::ParameterStorage) %shared_ptr(dynet::LookupParameterStorage) ``` SWIG warns that the base class "is not similarly marked as a smart pointer". The line below quiets the warning and also prevents crahes (because of double deletes?). ``` %shared_ptr(dynet::ParameterStorageBase) ``` An issue was filed previously and this will soon link to it.
|
This addresses issue #1502. |
|
This is failing because of a python configuration issue unrelated to this PR. The configuration should be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestio
2FE1
ns cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its subclasses are marked in dynet_swig.i as using shared pointers:
SWIG warns that the base class "is not similarly marked as a smart pointer". The line below quiets the warning and also prevents crahes (because of double deletes?).
An issue was filed previously and this will soon link to it.