8000 Swig fixes by akoehn · Pull Request #1331 · clab/dynet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Swig fixes #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2018
Merged

Swig fixes #1331

merged 2 commits into from
Mar 30, 2018

Conversation

akoehn
Copy link
Contributor
@akoehn akoehn commented Mar 28, 2018

swig bindings didn't work due to changes in the header files, esp. dynet::detail was not visible to swig anymore.

Also update one example to not use update_epoch anymore.

akoehn added 2 commits March 28, 2018 15:49
@akoehn
Fix swig bindings
c4f4c82 
 - move dynet::detail to expr.h so swig bindings can use it
 - two small fixes (include nodes.h, drop default parameter)
@akoehn
swig example: set learning rate instead of updateEpoch
b0edc3f
@neubig neubig merged commit 20fd674 into clab:master Mar 30, 2018
@neubig
Copy link
Contributor
neubig commented Mar 30, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akoehn @neubig
0