Optimize string replacements in camel/kebab case transformations #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #940 +/- ##
==========================================
+ Coverage 85.37% 85.73% +0.36%
==========================================
Files 75 78 +3
Lines 2386 2468 +82
Branches 174 175 +1
==========================================
+ Hits 2037 2116 +79
- Misses 349 352 +3
Continue to review full report at Codecov.
|
travisbrown
reviewed
Aug 10, 2018
| val default: Configuration = Configuration(Predef.identity, Predef.identity, false, None) | ||
| val basePattern: Pattern = Pattern.compile("([A-Z]+)([A-Z][a-z])") |
There was a problem hiding this comment.
Could you make these private? They shouldn't be needed outside of the implementations.
There was a problem hiding this comment.
Here are fast implementations of enforcing transformations for snake-case, kebab-case, and camelCase: https://github.com/plokhotnyuk/jsoniter-scala/blob/master/jsoniter-scala-macros/src/main/scala/com/github/plokhotnyuk/jsoniter_scala/macros/JsonCodecMaker.scala#L52-L98
Please, fill free to adopt them for your requirements.
|
@plokhotnyuk fast implementations are indeed much faster:
The thing is that they produce slightly different outputs, and I'm not sure it fits your needs: // plokhotnyuk implementation
Configuration.snakeCaseTransformation("SnakeCase")
Configuration.snakeCaseTransformation("snakeCase")
Configuration.snakeCaseTransformation("snakecase")
Configuration.snakeCaseTransformation("snake_case")
Configuration.snakeCaseTransformation("snake-case")
Configuration.snakeCaseTransformation("SNAKECASE")
Configuration.snakeCaseTransformation("")
Configuration.snakeCaseTransformation("sNaKeCaSe")
Configuration.snakeCaseTransformation("SNAKEcase")
Configuration.snakeCaseTransformation("SnakecasE")
//res0: String = _snake_case
//res1: String = snake_case
//res2: String = snakecase
//res3: String = snake_case
//res4: String = snake_case
//res5: String = snakecase
//res6: String =
//res7: String = s_na_ke_ca_se
//res8: String = snak_ecase
//res9: String = _snakecas_e
javaRegexSnakeCaseTransformation("SnakeCase")
javaRegexSnakeCaseTransformation("snakeCase")
javaRegexSnakeCaseTransformation("snakecase")
javaRegexSnakeCaseTransformation("snake_case")
javaRegexSnakeCaseTransformation("snake-case")
javaRegexSnakeCaseTransformation("SNAKECASE")
javaRegexSnakeCaseTransformation("")
javaRegexSnakeCaseTransformation("sNaKeCaSe")
javaRegexSnakeCaseTransformation("SNAKEcase")
javaRegexSnakeCaseTransformation("SnakecasE")
//res10: String = snake_case
//res11: String = snake_case
//res12: String = snakecase
//res13: String = snake_case
//res14: String = snake-case
//res15: String = snakecase
//res16: String =
//res17: String = s_na_ke_ca_se
//res18: String = snak_ecase
//res19: String = snakecas_e
// plokhotnyuk implementation
Configuration.kebabCaseTransformation("KnakeCase")
Configuration.kebabCaseTransformation("kebabCase")
Configuration.kebabCaseTransformation("kebabcase")
Configuration.kebabCaseTransformation("kebab_case")
Configuration.kebabCaseTransformation("kebab-case")
Configuration.kebabCaseTransformation("KEBABCASE")
Configuration.kebabCaseTransformation("")
Configuration.kebabCaseTransformation("kEbAbCaSe")
Configuration.kebabCaseTransformation("KEBABcase")
Configuration.kebabCaseTransformation("KebabcasE")
//res20: String = -knake-case
//res21: String = kebab-case
//res22: String = kebabcase
//res23: String = kebab-case
//res24: String = kebab-case
//res25: String = kebabcase
//res26: String =
//res27: String = k-eb-ab-ca-se
//res28: String = keba-bcase
//res29: String = -kebabcas-e
javaRegexKebabCaseTransformation("KnakeCase")
javaRegexKebabCaseTransformation("kebabCase")
javaRegexKebabCaseTransformation("kebabcase")
javaRegexKebabCaseTransformation("kebab_case")
javaRegexKebabCaseTransformation("kebab-case")
javaRegexKebabCaseTransformation("KEBABCASE")
javaRegexKebabCaseTransformation("")
javaRegexKebabCaseTransformation("kEbAbCaSe")
javaRegexKebabCaseTransformation("KEBABcase")
javaRegexKebabCaseTransformation("KebabcasE")
//res30: String = knake-case
//res31: String = kebab-case
//res32: String = kebabcase
//res33: String = kebab_case
//res34: String = kebab-case
//res35: String = kebabcase
//res36: String =
//res37: String = k-eb-ab-ca-se
//res38: String = keba-bcase
//res39: String = kebabcas-eLet me know how you want me to proceed? |
|
@waiter-melon thank you for your feedback! The leading I fixed it by the following commit: |
|
Could we discard faster implementation and just pre-compilation of regular expressions? We should include this in the next release I guess. |
0fe82e1 to
60ea793
Compare
|
Thanks, @waiter-melon—these commits will make it into 0.11.0 via #940. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-compiling regular expressions drastically improves camel-case and kebab-case transformations.
Here a benchmark focused on
snakeCasefunction.Before:
[info] KeyCasingBenchmark.snakeCase thrpt 10 829556.926 ± 59956.575 ops/sAfter:
[info] KeyCasingBenchmark.snakeCase thrpt 10 1861369.701 ± 52228.706 ops/s